netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: Olaf Hering <olh@suse.de>
Cc: linux-kernel@vger.kernel.org, netdev@oss.sgi.com
Subject: Re: [PATCH] compat bug in sys_recvmsg, MSG_CMSG_COMPAT check missing
Date: Sat, 5 Jun 2004 14:37:14 -0700	[thread overview]
Message-ID: <20040605143714.729744f8.davem@redhat.com> (raw)
In-Reply-To: <20040605211701.GD1134@suse.de>

On Sat, 5 Jun 2004 23:17:01 +0200
Olaf Hering <olh@suse.de> wrote:

>  On Sat, Jun 05, David S. Miller wrote:
> 
> > I can't see a reason, can anyone else?  If there is no reason, the
> > right fix is simply to mask it out at the top level, for both
> > sendmsg and recvmsg.
> 
> I did it first this way, but the result was a long delay until the dhcp
> server replied, the patch sent earlier leads to a fast reply.
> 
>     err = sock_recvmsg(sock, &msg_sys, total_len, flags & ~MSG_CMSG_COMPAT);

See my other email, net/core/scm.c needs this bit set all the
way down into the implementations.

  reply	other threads:[~2004-06-05 21:37 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-05 20:43 [PATCH] compat bug in sys_recvmsg, MSG_CMSG_COMPAT check missing Olaf Hering
2004-06-05 21:01 ` David S. Miller
2004-06-05 21:05   ` David S. Miller
2004-06-05 21:21     ` Andreas Schwab
2004-06-05 21:36       ` David S. Miller
2004-06-05 21:47         ` Andreas Schwab
2004-06-05 21:53           ` David S. Miller
2004-06-05 22:05             ` Andreas Schwab
2004-06-05 22:29               ` David S. Miller
2004-06-05 22:37                 ` Olaf Hering
2004-06-05 22:55                   ` David S. Miller
2004-06-05 21:17   ` Olaf Hering
2004-06-05 21:37     ` David S. Miller [this message]
2004-06-05 21:14 ` Olaf Hering

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040605143714.729744f8.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@oss.sgi.com \
    --cc=olh@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).