From: Olaf Hering <olh@suse.de>
To: linux-kernel@vger.kernel.org, netdev@oss.sgi.com
Subject: [PATCH] compat bug in sys_recvmsg, MSG_CMSG_COMPAT check missing
Date: Sat, 5 Jun 2004 22:43:34 +0200 [thread overview]
Message-ID: <20040605204334.GA1134@suse.de> (raw)
packet_recvmsg() gets the flags from the compat_sys_socketcall(), but it
does not check for the active MSG_CMSG_COMPAT bit. As a result, it
returns -EINVAL and makes the user rather unhappy
diff -purN linux-2.6.7-rc2-bk5.orig/net/packet/af_packet.c linux-2.6.7-rc2-bk5/net/packet/af_packet.c
--- linux-2.6.7-rc2-bk5.orig/net/packet/af_packet.c 2004-06-05 09:34:48.000000000 +0200
+++ linux-2.6.7-rc2-bk5/net/packet/af_packet.c 2004-06-05 22:32:16.000000000 +0200
@@ -1037,7 +1037,7 @@ static int packet_recvmsg(struct kiocb *
int copied, err;
err = -EINVAL;
- if (flags & ~(MSG_PEEK|MSG_DONTWAIT|MSG_TRUNC))
+ if (flags & ~(MSG_PEEK|MSG_DONTWAIT|MSG_TRUNC|MSG_CMSG_COMPAT))
goto out;
#if 0
--
USB is for mice, FireWire is for men!
sUse lINUX ag, nÜRNBERG
next reply other threads:[~2004-06-05 20:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-05 20:43 Olaf Hering [this message]
2004-06-05 21:01 ` [PATCH] compat bug in sys_recvmsg, MSG_CMSG_COMPAT check missing David S. Miller
2004-06-05 21:05 ` David S. Miller
2004-06-05 21:21 ` Andreas Schwab
2004-06-05 21:36 ` David S. Miller
2004-06-05 21:47 ` Andreas Schwab
2004-06-05 21:53 ` David S. Miller
2004-06-05 22:05 ` Andreas Schwab
2004-06-05 22:29 ` David S. Miller
2004-06-05 22:37 ` Olaf Hering
2004-06-05 22:55 ` David S. Miller
2004-06-05 21:17 ` Olaf Hering
2004-06-05 21:37 ` David S. Miller
2004-06-05 21:14 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040605204334.GA1134@suse.de \
--to=olh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).