netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [1/3][PATCH 2.6] via-rhine: fix mc_filter on big-endian arch
@ 2004-06-06 16:53 Roger Luethi
  0 siblings, 0 replies; only message in thread
From: Roger Luethi @ 2004-06-06 16:53 UTC (permalink / raw)
  To: Jeff Garzik, Andrew Morton; +Cc: netdev

A.J. from VIA Networking Technologies noticed that via-rhine is using
cpu_to_le32() when preparing mc_filter hashes. This breaks Rhine hardware
multicast filters on big-endian architectures.

Please apply.

Signed-off-by: Roger Luethi <rl@hellgate.ch>

--- 2.6-bk/drivers/net/via-rhine.c.orig	2004-06-06 18:03:21.323194221 +0200
+++ 2.6-bk/drivers/net/via-rhine.c	2004-06-06 18:05:22.137319854 +0200
@@ -1782,7 +1782,7 @@
 		     i++, mclist = mclist->next) {
 			int bit_nr = ether_crc(ETH_ALEN, mclist->dmi_addr) >> 26;
 
-			mc_filter[bit_nr >> 5] |= cpu_to_le32(1 << (bit_nr & 31));
+			mc_filter[bit_nr >> 5] |= 1 << (bit_nr & 31);
 		}
 		writel(mc_filter[0], ioaddr + MulticastFilter0);
 		writel(mc_filter[1], ioaddr + MulticastFilter1);

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2004-06-06 16:53 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-06-06 16:53 [1/3][PATCH 2.6] via-rhine: fix mc_filter on big-endian arch Roger Luethi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).