From: "David S. Miller" <davem@redhat.com>
To: Anton Blanchard <anton@samba.org>
Cc: netdev@oss.sgi.com
Subject: Re: Allow IP header alignment to be overriden
Date: Thu, 10 Jun 2004 22:35:49 -0700 [thread overview]
Message-ID: <20040610223549.5e9ad025.davem@redhat.com> (raw)
In-Reply-To: <20040611012727.GA27672@krispykreme>
On Fri, 11 Jun 2004 11:27:27 +1000
Anton Blanchard <anton@samba.org> wrote:
> The following patch creates skb_align and allows an architecture to
> override it. Thoughts?
This transformation is not valid for a lot of drivers, that "2"
in the reserve exists elsewhere in other calculations in the
drivers. For example, it is added to the RX skb allocation
size. Sometimes this '2' is there in non-trivial or hard to
see ways (ie. it's implicitly in some DMA alignment value)
That's the only reason I'm against this patch.
next prev parent reply other threads:[~2004-06-11 5:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-11 1:27 Allow IP header alignment to be overriden Anton Blanchard
2004-06-11 1:35 ` Andi Kleen
2004-06-11 1:43 ` Anton Blanchard
2004-06-11 5:35 ` David S. Miller [this message]
2004-06-11 7:39 ` Scott Feldman
2004-06-11 14:23 ` Anton Blanchard
2004-06-12 18:12 ` David S. Miller
2004-06-15 23:34 ` Anton Blanchard
2004-06-16 4:37 ` David S. Miller
2004-06-11 12:41 ` jamal
2004-06-11 14:08 ` Anton Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040610223549.5e9ad025.davem@redhat.com \
--to=davem@redhat.com \
--cc=anton@samba.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).