From: Mitchell Blank Jr <mitch@sfgoth.com>
To: Arthur Kepner <akepner@sgi.com>
Cc: netdev@oss.sgi.com
Subject: Re: [RFC/PATCH] lockless loopback patch for 2.6 (version 2)
Date: Mon, 14 Jun 2004 11:23:36 -0700 [thread overview]
Message-ID: <20040614182336.GC11280@gaz.sfgoth.com> (raw)
In-Reply-To: <Pine.SGI.4.56.0406141000060.479900@neteng.engr.sgi.com>
Arthur Kepner wrote:
> +#define HARD_TX_LOCK_BH(dev, cpu) { \
> + if ( dev->features && NETIF_F_LLTX == 0 ) { \
^^
Don't you mean '&' instead of '&&' here? It looks like that condition is
always false, so you've killed the TX locking for all devices with this
patch.
> + if ( dev->features && NETIF_F_LLTX == 0 ) { \
ditto
-Mitch
next prev parent reply other threads:[~2004-06-14 18:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-14 17:03 [RFC/PATCH] lockless loopback patch for 2.6 (version 2) Arthur Kepner
2004-06-14 18:23 ` Andi Kleen
2004-06-18 20:12 ` Arthur Kepner
2004-06-21 0:39 ` David S. Miller
2004-06-14 18:23 ` Mitchell Blank Jr [this message]
2004-06-14 19:45 ` Arthur Kepner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040614182336.GC11280@gaz.sfgoth.com \
--to=mitch@sfgoth.com \
--cc=akepner@sgi.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).