From: "David S. Miller" <davem@redhat.com>
To: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
Cc: herbert@gondor.apana.org.au, schwab@suse.de, netdev@oss.sgi.com,
yoshfuji@linux-ipv6.org
Subject: Re: 2.6.7-rc3: unregister_netdevice: waiting for tun0 to become free. Usage count = 1
Date: Wed, 16 Jun 2004 13:09:50 -0700 [thread overview]
Message-ID: <20040616130950.6aadde3c.davem@redhat.com> (raw)
In-Reply-To: <20040616193731.GB29781@ms2.inr.ac.ru>
On Wed, 16 Jun 2004 23:37:31 +0400
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru> wrote:
> Anyway, the comment remains damn true and the place is still
> bug. It makes sense to think about waiting for at least one quiescent
> state after detaching the stale device from dst and real dev_put() it.
> Reference to RCU is not occasional, the job looks natural for it.
It seems a simple synchronize_kernel() would clear all the
crap no?
===== net/core/dst.c 1.18 vs edited =====
--- 1.18/net/core/dst.c 2004-06-16 10:26:56 -07:00
+++ edited/net/core/dst.c 2004-06-16 13:10:37 -07:00
@@ -243,6 +243,8 @@
dst->ops->ifdown(dst, unregister);
} while ((dst = dst->child) && dst->flags & DST_NOHASH &&
dst->dev == dev);
+
+ synchronize_kernel();
}
static int dst_dev_event(struct notifier_block *this, unsigned long event, void *ptr)
next prev parent reply other threads:[~2004-06-16 20:09 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20040613121514.6b3c1c8a.davem@redhat.com>
2004-06-13 23:35 ` 2.6.7-rc3: unregister_netdevice: waiting for tun0 to become free. Usage count = 1 Herbert Xu
2004-06-13 23:41 ` Herbert Xu
2004-06-14 1:36 ` David S. Miller
2004-06-14 1:50 ` Herbert Xu
2004-06-14 4:07 ` David S. Miller
2004-06-14 4:22 ` Herbert Xu
2004-06-14 4:27 ` David S. Miller
2004-06-14 4:42 ` Herbert Xu
2004-06-14 4:47 ` Herbert Xu
2004-06-14 4:43 ` David S. Miller
2004-06-14 4:53 ` Herbert Xu
2004-06-14 10:28 ` Herbert Xu
2004-06-14 12:44 ` Herbert Xu
2004-06-16 19:37 ` Alexey Kuznetsov
2004-06-16 20:09 ` David S. Miller [this message]
2004-06-16 20:37 ` Alexey Kuznetsov
2004-06-16 20:47 ` David S. Miller
2004-06-17 8:17 ` Herbert Xu
2004-06-17 8:33 ` Herbert Xu
2004-06-17 17:10 ` David S. Miller
2004-06-17 17:24 ` Alexey Kuznetsov
2004-06-17 17:53 ` David S. Miller
2004-06-17 19:07 ` Alexey Kuznetsov
2004-06-17 19:16 ` David S. Miller
2004-06-17 21:29 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040616130950.6aadde3c.davem@redhat.com \
--to=davem@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@oss.sgi.com \
--cc=schwab@suse.de \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).