ip6_tables warning (was: Re: Linux 2.4.27-pre6)

ip6_tables warning (was: Re: Linux 2.4.27-pre6)

[Geert Uytterhoeven]

This is not a new problem, but I never bothered to report it before:

| ip6_tables.c: In function `tcp_match':
| ip6_tables.c:1596: warning: implicit declaration of function `ipv6_skip_exthdr'
It needs to include <net/ipv6.h> to kill the warning.

Sorry, no patch, since my development machine is offline.

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

Re: ip6_tables warning

[YOSHIFUJI Hideaki / 吉藤英明]

In article <Pine.GSO.4.58.0406171139020.22919@waterleaf.sonytel.be> (at Thu, 17 Jun 2004 12:06:17 +0200 (MEST)), Geert Uytterhoeven <geert@linux-m68k.org> says:

> This is not a new problem, but I never bothered to report it before:
> 
> | ip6_tables.c: In function `tcp_match':
> | ip6_tables.c:1596: warning: implicit declaration of function `ipv6_skip_exthdr'
> It needs to include <net/ipv6.h> to kill the warning.

Here it is.

===== net/ipv6/netfilter/ip6_tables.c 1.17 vs edited =====
--- 1.17/net/ipv6/netfilter/ip6_tables.c	2004-06-07 12:13:18 +09:00
+++ edited/net/ipv6/netfilter/ip6_tables.c	2004-06-17 19:11:08 +09:00
@@ -20,6 +20,7 @@
 #include <linux/udp.h>
 #include <linux/icmpv6.h>
 #include <net/ip.h>
+#include <net/ipv6.h>
 #include <asm/uaccess.h>
 #include <asm/semaphore.h>
 #include <linux/proc_fs.h>

-- 
Hideaki YOSHIFUJI @ USAGI Project <yoshfuji@linux-ipv6.org>
GPG FP: 9022 65EB 1ECF 3AD1 0BDF  80D8 4807 F894 E062 0EEA

Re: ip6_tables warning

[David S. Miller]

Applied, thanks Yoshfuji.

I've seen this too, just was too lazy to fix it :)

igmp warning (was: Re: Linux 2.4.27-pre6)

[Geert Uytterhoeven]

And this is a new one (compared to -pre3):

| igmp.c: In function `igmpv3_newpack':
| igmp.c:279: warning: `skb' might be used uninitialized in this function

And it seems to be a real bug, not a compiler glitch:

| static struct sk_buff *igmpv3_newpack(struct net_device *dev, int size)
| {
|         struct sk_buff *skb;
                          ^^^
|         struct rtable *rt;
|         struct iphdr *pip;
|         struct igmpv3_report *pig;
|         u32     dst;
|
|         dst = IGMPV3_ALL_MCR;
|         if (ip_route_output(&rt, dst, 0, 0, dev->ifindex))
|                 return 0;
|         if (rt->rt_src == 0) {
|                 kfree_skb(skb);
                            ^^^
|                 ip_rt_put(rt);
|                 return 0;
|         }


Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

Re: igmp warning (was: Re: Linux 2.4.27-pre6)

[David S. Miller]

Indeed, a 2.6.x bugfix got put into 2.4.x but it was not relevant
there at all.

Will fix this, thanks Geert.