netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] (1/4) delay scheduler enqueue always succeeds.
@ 2004-06-17 22:55 Stephen Hemminger
  2004-06-18 20:27 ` David S. Miller
  0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2004-06-17 22:55 UTC (permalink / raw)
  To: David S. Miller; +Cc: netdev, lartc

If underlying fifo enqueue fails, return the status not 0.
Same patch should apply to both 2.6 and 2.4

Signed-off-by: Stephen Hemminger <shemminger@osdl.org>

diff -Nru a/net/sched/sch_delay.c b/net/sched/sch_delay.c
--- a/net/sched/sch_delay.c	2004-06-17 15:13:15 -07:00
+++ b/net/sched/sch_delay.c	2004-06-17 15:13:15 -07:00
@@ -69,7 +69,7 @@
 		sch->stats.bytes += skb->len;
 		sch->stats.packets++;
 	}
-	return 0;
+	return ret;
 }
 
 /* Requeue packets but don't change time stamp */
_______________________________________________
LARTC mailing list / LARTC@mailman.ds9a.nl
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] (1/4) delay scheduler enqueue always succeeds.
@ 2004-06-17 22:57 Stephen Hemminger
  0 siblings, 0 replies; 3+ messages in thread
From: Stephen Hemminger @ 2004-06-17 22:57 UTC (permalink / raw)
  To: David S. Miller; +Cc: netdev, lartc

If underlying fifo enqueue fails, return the status not 0.
Same patch should apply to both 2.6 and 2.4

Signed-off-by: Stephen Hemminger <shemminger@osdl.org>

diff -Nru a/net/sched/sch_delay.c b/net/sched/sch_delay.c
--- a/net/sched/sch_delay.c	2004-06-17 15:13:15 -07:00
+++ b/net/sched/sch_delay.c	2004-06-17 15:13:15 -07:00
@@ -69,7 +69,7 @@
 		sch->stats.bytes += skb->len;
 		sch->stats.packets++;
 	}
-	return 0;
+	return ret;
 }
 
 /* Requeue packets but don't change time stamp */

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] (1/4) delay scheduler enqueue always succeeds.
  2004-06-17 22:55 [PATCH] (1/4) delay scheduler enqueue always succeeds Stephen Hemminger
@ 2004-06-18 20:27 ` David S. Miller
  0 siblings, 0 replies; 3+ messages in thread
From: David S. Miller @ 2004-06-18 20:27 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: netdev, lartc

On Thu, 17 Jun 2004 15:55:56 -0700
Stephen Hemminger <shemminger@osdl.org> wrote:

> If underlying fifo enqueue fails, return the status not 0.
> Same patch should apply to both 2.6 and 2.4

Duh :)  Applied, thanks Stephen.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2004-06-18 20:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-06-17 22:55 [PATCH] (1/4) delay scheduler enqueue always succeeds Stephen Hemminger
2004-06-18 20:27 ` David S. Miller
  -- strict thread matches above, loose matches on Subject: below --
2004-06-17 22:57 Stephen Hemminger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).