From: "David S. Miller" <davem@redhat.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: netdev@oss.sgi.com
Subject: Re: [IPSEC] Drop bogus NAT-T printks in esp_input
Date: Sat, 26 Jun 2004 11:36:03 -0700 [thread overview]
Message-ID: <20040626113603.2c928d1d.davem@redhat.com> (raw)
In-Reply-To: <20040626100718.GA28367@gondor.apana.org.au>
On Sat, 26 Jun 2004 20:07:18 +1000
Herbert Xu <herbert@gondor.apana.org.au> wrote:
> On Sat, Jun 26, 2004 at 11:57:15AM +1000, herbert wrote:
> >
> > However, printing a warning and then continuing is definitely wrong.
> > So expect a follow-up patch to drop the packet when encap_type is
> > unknown in esp_input.
>
> Here is the patch to drop the packet if encap_type is unknown.
> I've also removed the other two bogus printk's as they cannot
> occur (printing a message is the last thing you want to do even
> if they did occur :).
Also applied, thanks.
next prev parent reply other threads:[~2004-06-26 18:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-25 12:11 [UDP] Check encap_type at config time Herbert Xu
2004-06-25 12:35 ` [IPSEC] " Herbert Xu
2004-06-25 17:39 ` David S. Miller
2004-06-26 1:57 ` [IPSEC] Remove run-time encap_type checks in esp4 Herbert Xu
2004-06-26 10:07 ` [IPSEC] Drop bogus NAT-T printks in esp_input Herbert Xu
2004-06-26 18:36 ` David S. Miller [this message]
2004-06-26 18:35 ` [IPSEC] Remove run-time encap_type checks in esp4 David S. Miller
2004-06-25 17:37 ` [UDP] Check encap_type at config time David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040626113603.2c928d1d.davem@redhat.com \
--to=davem@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).