netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: Chris Wedgwood <cw@f00f.org>
Cc: chas@cmf.nrl.navy.mil, shemminger@osdl.org, netdev@oss.sgi.com
Subject: Re: [PATCH][ATM]: fix sparse checker warnings
Date: Sat, 26 Jun 2004 16:26:41 -0700	[thread overview]
Message-ID: <20040626162641.00786ed6.davem@redhat.com> (raw)
In-Reply-To: <20040626225230.GA12698@taniwha.stupidest.org>

On Sat, 26 Jun 2004 15:52:30 -0700
Chris Wedgwood <cw@f00f.org> wrote:

> > +++ b/net/atm/br2684.c	2004-06-22 14:04:02 -07:00
> > @@ -562,7 +562,7 @@
> >  	atmvcc->push = br2684_push;
> >  	skb_queue_head_init(&copy);
> >  	skb_migrate(&atmvcc->sk->sk_receive_queue, &copy);
> 
> > - -	while ((skb = skb_dequeue(&copy))) {
> > +	while ((skb = skb_dequeue(&copy)) != NULL) {
> 
> I know it's a matter of style, but I really hate the 'assignment in
> conditional' warning sparse spews out, especially when many people,
> myself included really do write while ((a = b)) --- the extra
> parentheses as a compromise to keep gcc quiet.

I think warning for the ((a=b)) case is annoying but not annoying
enough to fight against it :)

  parent reply	other threads:[~2004-06-26 23:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-26 22:45 [PATCH][ATM]: fix sparse checker warnings chas williams (contractor)
2004-06-26 22:52 ` Chris Wedgwood
2004-06-26 23:04   ` chas williams (contractor)
2004-06-26 23:27     ` David S. Miller
2004-06-26 23:26   ` David S. Miller [this message]
2004-06-26 23:42     ` CodingStyle: while ((a=b)) Chris Wedgwood
2004-06-27  1:20       ` chas williams (contractor)
2004-06-27  1:25         ` Chris Wedgwood
2004-06-27  4:07           ` chas williams (contractor)
2004-06-29  0:16     ` [PATCH][ATM]: fix sparse checker warnings Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040626162641.00786ed6.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=chas@cmf.nrl.navy.mil \
    --cc=cw@f00f.org \
    --cc=netdev@oss.sgi.com \
    --cc=shemminger@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).