From: Olaf Hering <olh@suse.de>
To: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, netdev@oss.sgi.com
Subject: [PATCH] signed bug in net/decnet/dn_nsp_in.c dn_nsp_linkservice()
Date: Mon, 28 Jun 2004 20:18:43 +0200 [thread overview]
Message-ID: <20040628181843.GA15021@suse.de> (raw)
net/decnet/dn_nsp_in.c:534: warning: comparison is always false due to limited range of data type
char can be either signed or unsigned, depending on the target system.
patch is against 2.6.7-bk11
--- ./net/decnet/dn_nsp_in.c
+++ ./net/decnet/dn_nsp_in.c 2004/06/28 18:11:40
@@ -504,7 +504,7 @@
struct dn_scp *scp = DN_SK(sk);
unsigned short segnum;
unsigned char lsflags;
- char fcval;
+ signed char fcval;
int wake_up = 0;
char *ptr = skb->data;
unsigned char fctype = scp->services_rem & NSP_FC_MASK;
--
USB is for mice, FireWire is for men!
sUse lINUX ag, nÜRNBERG
reply other threads:[~2004-06-28 18:18 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040628181843.GA15021@suse.de \
--to=olh@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).