netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] signed bug in net/decnet/dn_nsp_in.c dn_nsp_linkservice()
@ 2004-06-28 18:18 Olaf Hering
  0 siblings, 0 replies; only message in thread
From: Olaf Hering @ 2004-06-28 18:18 UTC (permalink / raw)
  To: Andrew Morton, linux-kernel, netdev


net/decnet/dn_nsp_in.c:534: warning: comparison is always false due to limited range of data type

char can be either signed or unsigned, depending on the target system.
patch is against 2.6.7-bk11


--- ./net/decnet/dn_nsp_in.c
+++ ./net/decnet/dn_nsp_in.c	2004/06/28 18:11:40
@@ -504,7 +504,7 @@
 	struct dn_scp *scp = DN_SK(sk);
 	unsigned short segnum;
 	unsigned char lsflags;
-	char fcval;
+	signed char fcval;
 	int wake_up = 0;
 	char *ptr = skb->data;
 	unsigned char fctype = scp->services_rem & NSP_FC_MASK;
-- 
USB is for mice, FireWire is for men!

sUse lINUX ag, nÜRNBERG

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2004-06-28 18:18 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-06-28 18:18 [PATCH] signed bug in net/decnet/dn_nsp_in.c dn_nsp_linkservice() Olaf Hering

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).