From: "David S. Miller" <davem@redhat.com>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: netdev@oss.sgi.com
Subject: Re: [PATCH] (2/4) packet scheduler bad TDIFF_SAFE in csz
Date: Tue, 29 Jun 2004 14:45:06 -0700 [thread overview]
Message-ID: <20040629144506.0649d217.davem@redhat.com> (raw)
In-Reply-To: <20040629140016.4afeb36b@dell_ss3.pdx.osdl.net>
On Tue, 29 Jun 2004 14:00:16 -0700
Stephen Hemminger <shemminger@osdl.org> wrote:
> This code in the csz scheduler, is just plain broken. The TDIFF_SAFE
> effectively expands to:
> unsigned long delay = now - q->t_c;
> if (delay > 0) {
> delay = 0;
> goto do_reset;
> }
> if (delay >> q->delta_log)
>
> So delay is always 0! I assume that what was originally intended
> is the to keep delay bounded to 1<<q->delta_log.
This bug has been there since day one, wow.
Good spotting, applied.
next prev parent reply other threads:[~2004-06-29 21:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-29 21:00 [PATCH] (2/4) packet scheduler bad TDIFF_SAFE in csz Stephen Hemminger
2004-06-29 21:45 ` David S. Miller [this message]
2004-06-29 22:22 ` jamal
2004-06-29 22:28 ` David S. Miller
2004-06-29 22:43 ` jamal
2004-06-29 22:49 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040629144506.0649d217.davem@redhat.com \
--to=davem@redhat.com \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).