netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
To: "David S. Miller" <davem@redhat.com>
Cc: Stephen Hemminger <shemminger@osdl.org>, netdev@oss.sgi.com
Subject: Re: [PATCH] TCP acts like it is always out of memory.
Date: Thu, 1 Jul 2004 22:32:25 -0300	[thread overview]
Message-ID: <20040702013225.GA24707@conectiva.com.br> (raw)
In-Reply-To: <20040701140406.62dfbc2a.davem@redhat.com>

Em Thu, Jul 01, 2004 at 02:04:06PM -0700, David S. Miller escreveu:
> On Thu, 1 Jul 2004 13:37:38 -0700
> Stephen Hemminger <shemminger@osdl.org> wrote:
> 
> > Current 2.6.7 tree acts as if it is alway under memory pressure because
> > a recent change did a s/tcp_memory_pressure/tcp_prot.memory_pressure/.
> > The problem is tcp_prot.memory_pressure is a pointer, so it is always non-zero!
> > 
> > Rather than using *tcp_prot.memory_pressure, just go back to looking at
> > tcp_memory_pressure.
> 
> Hehe, applied thanks Stephen.

:-) Thanks Stephen for the fix, this was a leftover of the conversion of
the memory pressure members in struct proto to pointers, to cover the case
pointed out by David related to the ipv6_mapped functionality in the
1.1722.122.23 changeset, (i.e.  tcp_prot and tcpv6_prot having to share the
same accounting variables), I forgot to convert all places where the
tcp_prot.memory_pressure memory is used, the fix is exactly what I should
have done. Due to family health problems I was unable to promply fix this
thinko, so, again, thank you very much.

Best Regards,

- Arnaldo

  reply	other threads:[~2004-07-02  1:32 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <32886.63.170.215.71.1088564087.squirrel@www.osdl.org>
     [not found] ` <20040629222751.392f0a82.davem@redhat.com>
     [not found]   ` <20040630152750.2d01ca51@dell_ss3.pdx.osdl.net>
     [not found]     ` <20040630153049.3ca25b76.davem@redhat.com>
2004-07-01 20:37       ` [PATCH] TCP acts like it is always out of memory Stephen Hemminger
2004-07-01 21:04         ` David S. Miller
2004-07-02  1:32           ` Arnaldo Carvalho de Melo [this message]
2004-07-06  9:35             ` analysis of TCP window size issues still around - several reports / SACK involved? bert hubert
2004-07-06 18:47               ` [PATCH] fix tcp_default_win_scale Stephen Hemminger
2004-07-06 19:40                 ` Jamie Lokier
2004-07-06 20:05                   ` Stephen Hemminger
2004-07-06 20:28                     ` David S. Miller
2004-07-06 20:36                       ` Stephen Hemminger
2004-07-06 20:35                         ` David S. Miller
2004-07-06 21:55                           ` John Heffner
2004-07-06 22:50                             ` David S. Miller
2004-07-07  1:32                               ` John Heffner
2004-07-06 23:01                           ` PLS help fix: recent 2.6.7 won't connect to anything " bert hubert
2004-07-06 20:12                   ` David S. Miller
2004-07-06 22:44                     ` bert hubert
2004-07-06 22:49                       ` David S. Miller
2004-07-07 18:06                         ` Stephen Hemminger
2004-07-07 19:31                           ` Jamie Lokier
2004-07-07 19:38                             ` bert hubert
2004-07-07 19:41                           ` John Heffner
2004-07-09 23:14                           ` David S. Miller
2004-07-06 20:00                 ` Nivedita Singhvi
2004-07-06 20:16                   ` David S. Miller
2004-07-06 20:26                     ` David Ford
     [not found]                 ` <20040706185856.GN18841@lug-owl.de>
2004-07-06 20:17                   ` David S. Miller
2004-07-06 20:31                     ` Stephen Hemminger
2004-07-06 20:33                       ` David S. Miller
2004-07-06 20:24                 ` David S. Miller
2004-07-06 23:16                   ` Andi Kleen
2004-07-07  7:50                     ` Chris Wedgwood
2004-07-06 23:19                 ` Redeeman
2004-07-07 19:47                 ` John Heffner
2004-07-06 20:19               ` analysis of TCP window size issues still around - several reports / SACK involved? David S. Miller
2004-07-06 20:27                 ` bert hubert
2004-07-06 20:31                   ` David S. Miller
2004-07-07 21:25                   ` Alessandro Suardi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040702013225.GA24707@conectiva.com.br \
    --to=acme@conectiva.com.br \
    --cc=davem@redhat.com \
    --cc=netdev@oss.sgi.com \
    --cc=shemminger@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).