netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: akpm@osdl.org
To: davem@redhat.com
Cc: netdev@oss.sgi.com, akpm@osdl.org
Subject: [patch 1/1] err1-28: rose_route locking fix
Date: Fri, 02 Jul 2004 01:11:17 -0700	[thread overview]
Message-ID: <200407020812.i628CFG17588@mail.osdl.org> (raw)



Fix deadlock in rose_del_loopback_node().  Found by the Stanford locking
checker.

Signed-off-by: Andrew Morton <akpm@osdl.org>
---

 25-akpm/net/rose/rose_route.c |    1 -
 1 files changed, 1 deletion(-)

diff -puN net/rose/rose_route.c~err1-28-rose_route-locking-fix net/rose/rose_route.c
--- 25/net/rose/rose_route.c~err1-28-rose_route-locking-fix	2004-07-02 01:09:27.377403248 -0700
+++ 25-akpm/net/rose/rose_route.c	2004-07-02 01:09:33.617454616 -0700
@@ -206,7 +206,6 @@ static void rose_remove_node(struct rose
 {
 	struct rose_node *s;
 
-	spin_lock_bh(&rose_node_list_lock);
 	if ((s = rose_node_list) == rose_node) {
 		rose_node_list = rose_node->next;
 		kfree(rose_node);
_

             reply	other threads:[~2004-07-02  8:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-02  8:11 akpm [this message]
2004-07-05 23:02 ` [patch 1/1] err1-28: rose_route locking fix David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200407020812.i628CFG17588@mail.osdl.org \
    --to=akpm@osdl.org \
    --cc=davem@redhat.com \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).