From: Andrew Morton <akpm@osdl.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: netdev@oss.sgi.com
Subject: Re: Fw: [BUGS] [CHECKER] 99 synchronization bugs and a lock summary database
Date: Fri, 2 Jul 2004 12:30:22 -0700 [thread overview]
Message-ID: <20040702123022.563ee931.akpm@osdl.org> (raw)
In-Reply-To: <E1BgLql-00055X-00@gondolin.me.apana.org.au>
Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> Andrew Morton <akpm@osdl.org> wrote:
> >
> > Could someone please take a look at the locking in
> > net/ipv4/ipmr.c:ipmr_mfc_seq_next? It seems rather broken.
>
> Obfuscated yes, broken no.
Really? Even if that goto
if (it->cache == &mfc_unres_queue)
goto end_of_list;
is taken?
Bizarre. It sure looks wrong. But then, if the author couldn't be
bothered describing the locking, I can't be bothered reverse engineering
it, so there.
> Unfortunately the seq interface tends to produce code like this.
Maybe. It could be that the locking in there is straightforward and
sensible. But because it is also secretly designed, we see what happens -
it wasted the Stanford guys' time, my time, your time, etc.
Sigh.
next prev parent reply other threads:[~2004-07-02 19:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-02 7:49 Fw: [BUGS] [CHECKER] 99 synchronization bugs and a lock summary database Andrew Morton
2004-07-02 11:04 ` Herbert Xu
2004-07-02 19:30 ` Andrew Morton [this message]
2004-07-02 19:50 ` Stephen Hemminger
2004-07-03 5:42 ` OGAWA Hirofumi
2004-07-03 6:13 ` Herbert Xu
2004-07-03 8:03 ` OGAWA Hirofumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040702123022.563ee931.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).