From: Olaf Hering <olh@suse.de>
To: cramerj@intel.com, netdev@oss.sgi.com
Subject: [PATCH] pass unsgined long to udelay in e1000
Date: Fri, 2 Jul 2004 20:17:44 +0200 [thread overview]
Message-ID: <20040702181744.GA18546@suse.de> (raw)
I get these warnings on ppc32 due to the check in udelay() macro.
Is it safe to move the struct member?
CC [M] drivers/net/e1000/e1000_hw.o
drivers/net/e1000/e1000_hw.c: In function `e1000_raise_ee_clk':
drivers/net/e1000/e1000_hw.c:3122: warning: comparison is always false due to limited range of data type
drivers/net/e1000/e1000_hw.c: In function `e1000_lower_ee_clk':
drivers/net/e1000/e1000_hw.c:3141: warning: comparison is always false due to limited range of data type
drivers/net/e1000/e1000_hw.c: In function `e1000_shift_out_ee_bits':
drivers/net/e1000/e1000_hw.c:3185: warning: comparison is always false due to limited range of data type
drivers/net/e1000/e1000_hw.c: In function `e1000_standby_eeprom':
drivers/net/e1000/e1000_hw.c:3314: warning: comparison is always false due to limited range of data type
drivers/net/e1000/e1000_hw.c:3320: warning: comparison is always false due to limited range of data type
drivers/net/e1000/e1000_hw.c:3326: warning: comparison is always false due to limited range of data type
drivers/net/e1000/e1000_hw.c:3332: warning: comparison is always false due to limited range of data type
drivers/net/e1000/e1000_hw.c:3338: warning: comparison is always false due to limited range of data type
drivers/net/e1000/e1000_hw.c:3342: warning: comparison is always false due to limited range of data type
drivers/net/e1000/e1000_hw.c: In function `e1000_release_eeprom':
drivers/net/e1000/e1000_hw.c:3366: warning: comparison is always false due to limited range of data type
drivers/net/e1000/e1000_hw.c:3379: warning: comparison is always false due to limited range of data type
drivers/net/e1000/e1000_hw.c:3385: warning: comparison is always false due to limited range of data type
patch is against 2.6.7-bk15
--- ./drivers/net/e1000/e1000_hw.h
+++ ./drivers/net/e1000/e1000_hw.h 2004/07/02 18:07:28
@@ -234,8 +234,8 @@ struct e1000_eeprom_info {
uint16_t word_size;
uint16_t opcode_bits;
uint16_t address_bits;
- uint16_t delay_usec;
uint16_t page_size;
+ unsigned long delay_usec;
};
--
USB is for mice, FireWire is for men!
sUse lINUX ag, nÜRNBERG
reply other threads:[~2004-07-02 18:17 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040702181744.GA18546@suse.de \
--to=olh@suse.de \
--cc=cramerj@intel.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).