[NETLINK] Return err in netlink_connect

[NETLINK] Return err in netlink_connect

[Herbert Xu]

[-- Attachment #1: Type: text/plain, Size: 583 bytes --]

Hi:

This patch makes netlink_connect() return the value of err instead of 0.
It doesn't actually make any difference since the current implementation
of netlink_autobind() never fails.  But since we went to all this trouble
to check the return status of autobind, might as well return the correct
value :)

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[-- Attachment #2: p --]
[-- Type: text/plain, Size: 370 bytes --]

===== net/netlink/af_netlink.c 1.49 vs edited =====
--- 1.49/net/netlink/af_netlink.c	2004-06-30 21:28:39 +10:00
+++ edited/net/netlink/af_netlink.c	2004-06-30 21:36:36 +10:00
@@ -386,7 +386,7 @@
 		nlk->dst_groups = nladdr->nl_groups;
 	}
 
-	return 0;
+	return err;
 }
 
 static int netlink_getname(struct socket *sock, struct sockaddr *addr, int *addr_len, int peer)

Re: [NETLINK] Return err in netlink_connect

[David S. Miller]

On Wed, 30 Jun 2004 21:41:44 +1000
Herbert Xu <herbert@gondor.apana.org.au> wrote:

> This patch makes netlink_connect() return the value of err instead of 0.
> It doesn't actually make any difference since the current implementation
> of netlink_autobind() never fails.  But since we went to all this trouble
> to check the return status of autobind, might as well return the correct
> value :)
> 
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Applied, thanks Herbert.