netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [patch 1/1] err1-62: ax25_ds_idletimer_expiry() locking fix
@ 2004-07-02  8:28 akpm
  2004-07-05 23:03 ` David S. Miller
  0 siblings, 1 reply; 2+ messages in thread
From: akpm @ 2004-07-02  8:28 UTC (permalink / raw)
  To: davem; +Cc: netdev, akpm



Fix deadlock identified by the Stanford locking checker.

Signed-off-by: Andrew Morton <akpm@osdl.org>
---

 25-akpm/net/ax25/ax25_ds_timer.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -puN net/ax25/ax25_ds_timer.c~err1-62-ax25_ds_idletimer_expiry-locking-fix net/ax25/ax25_ds_timer.c
--- 25/net/ax25/ax25_ds_timer.c~err1-62-ax25_ds_idletimer_expiry-locking-fix	2004-07-02 01:27:07.504239472 -0700
+++ 25-akpm/net/ax25/ax25_ds_timer.c	2004-07-02 01:27:11.824582680 -0700
@@ -180,7 +180,7 @@ void ax25_ds_idletimer_expiry(ax25_cb *a
 			ax25->sk->sk_state_change(ax25->sk);
 			sock_set_flag(ax25->sk, SOCK_DEAD);
 		}
-		bh_lock_sock(ax25->sk);
+		bh_unlock_sock(ax25->sk);
 	}
 }
 
_

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [patch 1/1] err1-62: ax25_ds_idletimer_expiry() locking fix
  2004-07-02  8:28 [patch 1/1] err1-62: ax25_ds_idletimer_expiry() locking fix akpm
@ 2004-07-05 23:03 ` David S. Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David S. Miller @ 2004-07-05 23:03 UTC (permalink / raw)
  To: akpm; +Cc: netdev, akpm

On Fri, 02 Jul 2004 01:28:24 -0700
akpm@osdl.org wrote:

> Fix deadlock identified by the Stanford locking checker.
> 
> Signed-off-by: Andrew Morton <akpm@osdl.org>

Applied.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-07-05 23:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-07-02  8:28 [patch 1/1] err1-62: ax25_ds_idletimer_expiry() locking fix akpm
2004-07-05 23:03 ` David S. Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).