* [patch 1/1] err2-15: ax25_rt_add() locking fix
@ 2004-07-02 8:46 akpm
2004-07-05 23:05 ` David S. Miller
0 siblings, 1 reply; 2+ messages in thread
From: akpm @ 2004-07-02 8:46 UTC (permalink / raw)
To: davem; +Cc: netdev, akpm
It can return with the lock held.
Found by the Stanford locking checker
Signed-off-by: Andrew Morton <akpm@osdl.org>
---
25-akpm/net/ax25/ax25_route.c | 1 +
1 files changed, 1 insertion(+)
diff -puN net/ax25/ax25_route.c~err2-15-ax25_rt_add-locking-fix net/ax25/ax25_route.c
--- 25/net/ax25/ax25_route.c~err2-15-ax25_rt_add-locking-fix 2004-07-02 01:45:20.234119280 -0700
+++ 25-akpm/net/ax25/ax25_route.c 2004-07-02 01:45:37.960424472 -0700
@@ -122,6 +122,7 @@ static int ax25_rt_add(struct ax25_route
ax25_rt->digipeat->calls[i] = route->digi_addr[i];
}
}
+ write_unlock(&ax25_route_lock);
return 0;
}
ax25_rt = ax25_rt->next;
_
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch 1/1] err2-15: ax25_rt_add() locking fix
2004-07-02 8:46 [patch 1/1] err2-15: ax25_rt_add() locking fix akpm
@ 2004-07-05 23:05 ` David S. Miller
0 siblings, 0 replies; 2+ messages in thread
From: David S. Miller @ 2004-07-05 23:05 UTC (permalink / raw)
To: akpm; +Cc: netdev, akpm
On Fri, 02 Jul 2004 01:46:23 -0700
akpm@osdl.org wrote:
> It can return with the lock held.
>
> Found by the Stanford locking checker
>
> Signed-off-by: Andrew Morton <akpm@osdl.org>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-07-05 23:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-07-02 8:46 [patch 1/1] err2-15: ax25_rt_add() locking fix akpm
2004-07-05 23:05 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).