netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
To: jamal <hadi@cyberus.ca>
Cc: "David S. Miller" <davem@redhat.com>,
	Stephen Hemminger <shemminger@osdl.org>,
	netdev@oss.sgi.com
Subject: Re: bk16 changes to cbq
Date: Tue, 6 Jul 2004 00:27:27 +0400	[thread overview]
Message-ID: <20040705202727.GA21226@ms2.inr.ac.ru> (raw)
In-Reply-To: <1088861810.1039.298.camel@jzny.localdomain>

Hello!

> What i remember is this (4-5 years back) used to cure a bug - cant
> remember the details unfortunately, but Alexey may remember.

Actually, I do not. It looks like an optimization: if the device is
throttled we just do not need to add timer, qdisc will be woken up
by unthrottle. I do not see any race condition here, but also I do not
see why this check could be important.

> At the expense of repeating a discussion that may have already happened,

To be honest, I wish to be reminded. If this check cured something,
it would be interesting to know what was this.

Alexey

  parent reply	other threads:[~2004-07-05 20:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-03 13:36 bk16 changes to cbq jamal
2004-07-03 17:16 ` David S. Miller
2004-07-04  0:03   ` jamal
2004-07-04  1:21   ` jamal
2004-07-05 20:27 ` Alexey Kuznetsov [this message]
2004-07-06  1:28   ` jamal
2004-07-07  5:13   ` David S. Miller
2004-07-07 15:59     ` Alexey Kuznetsov
2004-07-07 18:11       ` jamal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040705202727.GA21226@ms2.inr.ac.ru \
    --to=kuznet@ms2.inr.ac.ru \
    --cc=davem@redhat.com \
    --cc=hadi@cyberus.ca \
    --cc=netdev@oss.sgi.com \
    --cc=shemminger@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).