From: Herbert Xu <herbert@gondor.apana.org.au>
To: "David S. Miller" <davem@redhat.com>
Cc: netdev@oss.sgi.com
Subject: Re: [XFRM] Convert XFRM_MSG_* macros to an enum
Date: Tue, 6 Jul 2004 09:21:41 +1000 [thread overview]
Message-ID: <20040705232141.GA9939@gondor.apana.org.au> (raw)
In-Reply-To: <20040705161148.503722e7.davem@redhat.com>
On Mon, Jul 05, 2004 at 04:11:48PM -0700, David S. Miller wrote:
>
> > I'd like to add two new xfrm_user messages, FLUSHSA and FLUSHPOLICY.
> >
> > I've cleaned up the existing MSG definitions by converting them to
> > an enum. This should make future additions slightly easier in that
> > XFRM_MSG_MAX won't have to be touched again.
>
> If we end up needing the define macros anyways, after that discussion
> with Yoshifuji, I don't see the point to this change any more and
> therefore I'm not going to apply it.
The point is that with enums we won't have to change XFRM_MSG_MAX
every time a new message type is added.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2004-07-05 23:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-03 9:52 [XFRM] Convert XFRM_MSG_* macros to an enum Herbert Xu
2004-07-03 10:00 ` YOSHIFUJI Hideaki / 吉藤英明
2004-07-03 10:02 ` Herbert Xu
2004-07-03 10:10 ` Herbert Xu
2004-07-03 10:04 ` YOSHIFUJI Hideaki / 吉藤英明
2004-07-05 23:11 ` David S. Miller
2004-07-05 23:21 ` Herbert Xu [this message]
2004-07-05 23:47 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040705232141.GA9939@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@redhat.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).