* [PATCH] mark CSZ scheduler as broken
@ 2004-07-07 18:19 Stephen Hemminger
2004-07-07 20:32 ` bert hubert
2004-07-07 22:28 ` David S. Miller
0 siblings, 2 replies; 6+ messages in thread
From: Stephen Hemminger @ 2004-07-07 18:19 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev
Since the configuration help for CSZ is broken, and other documentation
says it just doesn't work. Why not mark it as broken to make it obvious?
Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
diff -Nru a/net/sched/Kconfig b/net/sched/Kconfig
--- a/net/sched/Kconfig 2004-07-07 11:18:01 -07:00
+++ b/net/sched/Kconfig 2004-07-07 11:18:01 -07:00
@@ -51,7 +51,7 @@
config NET_SCH_CSZ
tristate "CSZ packet scheduler"
- depends on NET_SCHED
+ depends on NET_SCHED && BROKEN
---help---
Say Y here if you want to use the Clark-Shenker-Zhang (CSZ) packet
scheduling algorithm for some of your network devices. At the
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mark CSZ scheduler as broken
2004-07-07 18:19 [PATCH] mark CSZ scheduler as broken Stephen Hemminger
@ 2004-07-07 20:32 ` bert hubert
2004-07-07 22:27 ` David S. Miller
2004-07-07 22:28 ` David S. Miller
1 sibling, 1 reply; 6+ messages in thread
From: bert hubert @ 2004-07-07 20:32 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: David S. Miller, netdev
On Wed, Jul 07, 2004 at 11:19:36AM -0700, Stephen Hemminger wrote:
> Since the configuration help for CSZ is broken, and other documentation
> says it just doesn't work. Why not mark it as broken to make it obvious?
For all I care we can zonk it - even Alexey is unclear about its workings or
use. More of a research project then something we should ship.
--
http://www.PowerDNS.com Open source, database driven DNS Software
http://lartc.org Linux Advanced Routing & Traffic Control HOWTO
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mark CSZ scheduler as broken
2004-07-07 20:32 ` bert hubert
@ 2004-07-07 22:27 ` David S. Miller
0 siblings, 0 replies; 6+ messages in thread
From: David S. Miller @ 2004-07-07 22:27 UTC (permalink / raw)
To: bert hubert; +Cc: shemminger, netdev
On Wed, 7 Jul 2004 22:32:45 +0200
bert hubert <ahu@ds9a.nl> wrote:
> On Wed, Jul 07, 2004 at 11:19:36AM -0700, Stephen Hemminger wrote:
> > Since the configuration help for CSZ is broken, and other documentation
> > says it just doesn't work. Why not mark it as broken to make it obvious?
>
> For all I care we can zonk it - even Alexey is unclear about its workings or
> use. More of a research project then something we should ship.
Let's do it in 2.7.x, not in 2.6.x
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mark CSZ scheduler as broken
2004-07-07 18:19 [PATCH] mark CSZ scheduler as broken Stephen Hemminger
2004-07-07 20:32 ` bert hubert
@ 2004-07-07 22:28 ` David S. Miller
2004-07-07 23:56 ` Stephen Hemminger
1 sibling, 1 reply; 6+ messages in thread
From: David S. Miller @ 2004-07-07 22:28 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: netdev
On Wed, 7 Jul 2004 11:19:36 -0700
Stephen Hemminger <shemminger@osdl.org> wrote:
> Since the configuration help for CSZ is broken, and other documentation
> says it just doesn't work. Why not mark it as broken to make it obvious?
I think marking it as experimental is more appropriate and
accurate. Don't you think?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mark CSZ scheduler as broken
2004-07-07 22:28 ` David S. Miller
@ 2004-07-07 23:56 ` Stephen Hemminger
2004-07-09 23:15 ` David S. Miller
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Hemminger @ 2004-07-07 23:56 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev
On Wed, 7 Jul 2004 15:28:03 -0700
"David S. Miller" <davem@redhat.com> wrote:
> On Wed, 7 Jul 2004 11:19:36 -0700
> Stephen Hemminger <shemminger@osdl.org> wrote:
>
> > Since the configuration help for CSZ is broken, and other documentation
> > says it just doesn't work. Why not mark it as broken to make it obvious?
>
> I think marking it as experimental is more appropriate and
> accurate. Don't you think?
It builds fine and obeys all the conventions, so it isn't really BROKEN like
other drivers. But do we really want to keep it in the tree at all? The code to
set it up isn't in the any version of 'tc' I saw (only stubs).
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mark CSZ scheduler as broken
2004-07-07 23:56 ` Stephen Hemminger
@ 2004-07-09 23:15 ` David S. Miller
0 siblings, 0 replies; 6+ messages in thread
From: David S. Miller @ 2004-07-09 23:15 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: netdev
On Wed, 7 Jul 2004 16:56:28 -0700
Stephen Hemminger <shemminger@osdl.org> wrote:
> It builds fine and obeys all the conventions, so it isn't really BROKEN like
> other drivers. But do we really want to keep it in the tree at all? The code to
> set it up isn't in the any version of 'tc' I saw (only stubs).
Ok, I've been thinking about this a bit and we can just
kill it from the 2.6.x tree.
I'll do that.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2004-07-09 23:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-07-07 18:19 [PATCH] mark CSZ scheduler as broken Stephen Hemminger
2004-07-07 20:32 ` bert hubert
2004-07-07 22:27 ` David S. Miller
2004-07-07 22:28 ` David S. Miller
2004-07-07 23:56 ` Stephen Hemminger
2004-07-09 23:15 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).