From: Adrian Bunk <bunk@fs.tum.de>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: linux-net@vger.kernel.org, Netdev <netdev@oss.sgi.com>
Subject: Re: [2.6 patch] net/hamradio/dmascc: remove inlines
Date: Sat, 10 Jul 2004 19:16:28 +0200 [thread overview]
Message-ID: <20040710171628.GT28324@fs.tum.de> (raw)
In-Reply-To: <40F020C7.5010608@pobox.com>
On Sat, Jul 10, 2004 at 01:00:55PM -0400, Jeff Garzik wrote:
>...
> It seems like you are going directly against the intent of the author,
> with this patch.
The intend of the author might have been different - but the author
didn't notice that his inlines never had any effect since the ordering
of the functions was wrong.
I could send a patch to reorder the file to get the inlines working, but
I heavily doubt inlining e.g. rx_on would be an improvement.
> Jeff
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2004-07-10 17:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20040710010414.GX28324@fs.tum.de>
2004-07-10 17:00 ` [2.6 patch] net/hamradio/dmascc: remove inlines Jeff Garzik
2004-07-10 17:16 ` Adrian Bunk [this message]
2004-07-12 23:04 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040710171628.GT28324@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=jgarzik@pobox.com \
--cc=linux-net@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).