From: Andi Kleen <ak@suse.de>
To: "Rusty Russell (IBM)" <rusty@au1.ibm.com>
Cc: netdev@oss.sgi.com
Subject: Re: Fragment ID wrap workaround (read-only, untested).
Date: Thu, 15 Jul 2004 19:34:09 +0200 [thread overview]
Message-ID: <20040715173409.GA14193@wotan.suse.de> (raw)
In-Reply-To: <1089873416.6583.1.camel@bach>
> + * other end detect ID wrap. */
> + if (skb->sk) {
> + unsigned int slack;
> + struct inet_opt *inet = inet_sk(skb->sk);
> +
> + slack = (left % mtu);
> + if (slack)
> + /* Shift by 8 bytes per id wrap. */
> + len = mtu - (slack % ((inet->id >> 16) << 3));
I'm pretty sure inet->id is wrong here. You would like the counter
in the inet peer entry. inet_sk(sk)->id is just used for the pseudo
counter in TCP that only works around VJ compression bugs. It's never used
for real fragmentation.
-Andi
next prev parent reply other threads:[~2004-07-15 17:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-15 6:36 Fragment ID wrap workaround (read-only, untested) Rusty Russell (IBM)
2004-07-15 17:34 ` Andi Kleen [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-07-15 5:57 Rusty Russell (IBM)
2004-07-15 8:28 ` David Stevens
2004-07-15 9:27 ` Andi Kleen
2004-07-15 14:49 ` David Stevens
2004-07-15 16:24 ` John Heffner
2004-07-15 16:27 ` Andi Kleen
2004-07-15 16:54 ` David Stevens
2004-07-15 17:02 ` Andi Kleen
2004-07-27 12:38 ` Olaf Kirch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040715173409.GA14193@wotan.suse.de \
--to=ak@suse.de \
--cc=netdev@oss.sgi.com \
--cc=rusty@au1.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).