From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andi Kleen Subject: Re: [PATCH] Drop ISA dependencies from IRDA drivers Date: 16 Jul 2004 07:45:50 +0200 Sender: netdev-bounce@oss.sgi.com Message-ID: <20040716054550.GA21819@muc.de> References: <20040715215552.GA46635@muc.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jeff Garzik , netdev@oss.sgi.com, irda-users@lists.sourceforge.net, jt@hpl.hp.com, the_nihilant@autistici.org, Linux Kernel Return-path: Date: Fri, 16 Jul 2004 07:45:50 +0200 To: Martin Diehl Content-Disposition: inline In-Reply-To: Errors-to: netdev-bounce@oss.sgi.com List-Id: netdev.vger.kernel.org On Fri, Jul 16, 2004 at 12:32:44AM +0200, Martin Diehl wrote: > On 15 Jul 2004, Andi Kleen wrote: > > > Remove wrong ISA dependencies for IRDA drivers. > > > > > > diff -u linux-2.6.8rc1-amd64/drivers/net/irda/Kconfig-o linux-2.6.8rc1-amd64/drivers/net/irda/Kconfig > > --- linux-2.6.8rc1-amd64/drivers/net/irda/Kconfig-o 2004-07-12 06:09:05.000000000 +0200 > > +++ linux-2.6.8rc1-amd64/drivers/net/irda/Kconfig 2004-07-15 18:33:48.000000000 +0200 > > @@ -310,7 +310,7 @@ > > > > config NSC_FIR > > tristate "NSC PC87108/PC87338" > > - depends on IRDA && ISA > > + depends on IRDA > > > Admittedly I haven't tried either, but I'm pretty sure this patch will > break building those drivers because they are calling irda_setup_dma - > which is CONFIG_ISA. Maybe this can be dropped but I don't see what's > wrong with !64BIT instead. Hmm, good point. !64BIT is not needed - apparently they are 64bit clean. The reason I want to drop the CONFIG_ISA depency is that they *should* be built on x86-64 too. -Andi