From: "David S. Miller" <davem@redhat.com>
To: Patrick McHardy <kaber@trash.net>
Cc: shemminger@osdl.org, netdev@oss.sgi.com, devik@cdi.cz
Subject: Re: [PATCH 2.6]: Make packet scheduler clock source configurable
Date: Wed, 21 Jul 2004 14:31:10 -0700 [thread overview]
Message-ID: <20040721143110.4ab944bf.davem@redhat.com> (raw)
In-Reply-To: <40F4AC8B.40706@trash.net>
On Wed, 14 Jul 2004 05:46:19 +0200
Patrick McHardy <kaber@trash.net> wrote:
> This one actually compiles ;). The assembler of PSCHED_GET_TIME is
> exactly the same on x86. There are 10 architectures that return
> something non-zero for get_cycles(), but I have no idea if it is
> suitable on all of them. Patch applies on top of the dead-code
> removal patch.
This looks great.
As you mention some platforms return zero, for example sparc32,
for get_cycles().
I suggest we just expand the dependency list for NET_SCH_CLK_TSC
to include SPARC64 PPC64 and perhaps some other easy to verify
as having a working get_cycles() implementation. I believe that
as long as it increments at some rate >= jiffies, the psched
calibration will get things into a working state.
A lot of patches have been posted in this area and I'm losing
track of what to apply first etc. Can you repost your work
one change at a time? Thanks.
next prev parent reply other threads:[~2004-07-21 21:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-13 2:21 [PATCH 2.6]: Make packet scheduler clock source configurable Patrick McHardy
2004-07-13 3:35 ` shemminger
2004-07-13 3:50 ` David S. Miller
[not found] ` <40F4862D.3070802@trash.net>
[not found] ` <40F4AC8B.40706@trash.net>
2004-07-21 21:31 ` David S. Miller [this message]
2004-07-22 23:36 ` Patrick McHardy
2004-07-23 0:17 ` David S. Miller
2004-07-23 0:52 ` Patrick McHardy
2004-07-23 1:00 ` Patrick McHardy
2004-07-23 1:03 ` David S. Miller
2004-07-23 17:14 ` Patrick McHardy
2004-07-23 17:53 ` Stephen Hemminger
2004-07-23 20:54 ` David S. Miller
2004-07-23 23:18 ` Patrick McHardy
2004-07-25 6:27 ` David S. Miller
2004-07-25 21:56 ` Patrick McHardy
2004-07-26 0:02 ` David S. Miller
2004-07-23 20:57 ` David S. Miller
2004-07-23 23:21 ` Patrick McHardy
2004-07-13 16:16 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040721143110.4ab944bf.davem@redhat.com \
--to=davem@redhat.com \
--cc=devik@cdi.cz \
--cc=kaber@trash.net \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).