* Re: [PATCH] br2684 - use try_module_get appropriately
[not found] <20040628093317.218220fe@dell_ss3.pdx.osdl.net>
@ 2004-07-19 21:36 ` chas williams (contractor)
2004-07-21 23:15 ` David S. Miller
0 siblings, 1 reply; 2+ messages in thread
From: chas williams (contractor) @ 2004-07-19 21:36 UTC (permalink / raw)
To: davem; +Cc: netdev, Stephen Hemminger
In message <20040628093317.218220fe@dell_ss3.pdx.osdl.net>,Stephen Hemminger wr
ites:
>Either way, just an (void) try_module_get() is WRONG.
dave, please apply to 2.6 --thanks
# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
# ChangeSet 1.1819 -> 1.1820
# net/atm/pppoatm.c 1.12 -> 1.13
# net/atm/br2684.c 1.12 -> 1.13
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 04/07/19 chas@relax.cmf.nrl.navy.mil 1.1820
# [ATM]: use try_module_get appropriately (from Stephen Hemminger <shemminger@osdl.org>)
# --------------------------------------------
#
diff -Nru a/net/atm/br2684.c b/net/atm/br2684.c
--- a/net/atm/br2684.c Mon Jul 19 17:33:00 2004
+++ b/net/atm/br2684.c Mon Jul 19 17:33:00 2004
@@ -563,7 +563,7 @@
BRPRIV(skb->dev)->stats.rx_packets--;
br2684_push(atmvcc, skb);
}
- (void) try_module_get(THIS_MODULE);
+ __module_get(THIS_MODULE);
return 0;
error:
write_unlock_irq(&devs_lock);
diff -Nru a/net/atm/pppoatm.c b/net/atm/pppoatm.c
--- a/net/atm/pppoatm.c Mon Jul 19 17:33:00 2004
+++ b/net/atm/pppoatm.c Mon Jul 19 17:33:00 2004
@@ -307,7 +307,7 @@
atmvcc->user_back = pvcc;
atmvcc->push = pppoatm_push;
atmvcc->pop = pppoatm_pop;
- (void) try_module_get(THIS_MODULE);
+ __module_get(THIS_MODULE);
return 0;
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] br2684 - use try_module_get appropriately
2004-07-19 21:36 ` [PATCH] br2684 - use try_module_get appropriately chas williams (contractor)
@ 2004-07-21 23:15 ` David S. Miller
0 siblings, 0 replies; 2+ messages in thread
From: David S. Miller @ 2004-07-21 23:15 UTC (permalink / raw)
To: chas williams (contractor); +Cc: netdev, shemminger
On Mon, 19 Jul 2004 17:36:05 -0400
"chas williams (contractor)" <chas@cmf.nrl.navy.mil> wrote:
> In message <20040628093317.218220fe@dell_ss3.pdx.osdl.net>,Stephen Hemminger wr
> ites:
> >Either way, just an (void) try_module_get() is WRONG.
>
> dave, please apply to 2.6 --thanks
Applied, thanks guys.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-07-21 23:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20040628093317.218220fe@dell_ss3.pdx.osdl.net>
2004-07-19 21:36 ` [PATCH] br2684 - use try_module_get appropriately chas williams (contractor)
2004-07-21 23:15 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).