From: "YOSHIFUJI Hideaki / 吉藤英明" <yoshfuji@linux-ipv6.org>
To: hadi@znyx.com
Cc: shemminger@osdl.org, davem@redhat.com, arekm@pld-linux.org,
netdev@oss.sgi.com, yoshfuji@linux-ipv6.org
Subject: Re: [PATCH] pkt_cls.h incompatiables
Date: Fri, 23 Jul 2004 11:00:07 -0400 (EDT) [thread overview]
Message-ID: <20040723.110007.27520072.yoshfuji@linux-ipv6.org> (raw)
In-Reply-To: <1090593676.1128.25.camel@jzny.localdomain>
In article <1090593676.1128.25.camel@jzny.localdomain> (at 23 Jul 2004 10:41:16 -0400), Jamal Hadi Salim <hadi@znyx.com> says:
> > Solutions are, for example,
> > to allocate new TCA_U32_xxx for rcnt and rhit,
> > or,
> > to rename TCA_U32_SEL to TCA_U32_OLS_SEL and allocate new value for
> > TCA_U32_SEL.
>
>
> we could do this, but since we are already fscking the ABI it is not
> valuable.
BTW, what's for rcnt etc.? I don't see the point.
They're not (effectively) used in kernel.
I'd suggest to remove these things and to maintain the original ABI.
If rcnt etc. are for other purposes, such as statistics for userspace,
please allocate another structure / interface for it.
(And... cheking size is too strict;
we need to relax it to accept old binaries if we add something
at the tail of structure.)
Thanks.
--yoshfuji
next prev parent reply other threads:[~2004-07-23 15:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200407161544.59342.arekm@pld-linux.org>
[not found] ` <20040716103759.1928c2ae@dell_ss3.pdx.osdl.net>
[not found] ` <200407172357.15832.arekm@pld-linux.org>
2004-07-22 20:45 ` [PATCH] pkt_cls.h incompatiables Stephen Hemminger
2004-07-22 20:53 ` David S. Miller
2004-07-23 0:04 ` YOSHIFUJI Hideaki / 吉藤英明
2004-07-23 14:41 ` Jamal Hadi Salim
2004-07-23 15:00 ` YOSHIFUJI Hideaki / 吉藤英明 [this message]
2004-07-23 16:21 ` Stephen Hemminger
2004-07-23 20:25 ` Jamal Hadi Salim
2004-07-23 19:57 ` Jamal Hadi Salim
2004-07-23 20:59 ` David S. Miller
2004-07-24 0:49 ` Jamal Hadi Salim
2004-07-24 1:42 ` YOSHIFUJI Hideaki / 吉藤英明
2004-07-24 12:16 ` Jamal Hadi Salim
2004-07-24 13:33 ` jamal
2004-07-25 1:33 ` YOSHIFUJI Hideaki / 吉藤英明
2004-07-25 6:25 ` David S. Miller
2004-07-25 5:28 ` David S. Miller
2004-07-29 11:22 ` jamal
2004-07-29 11:30 ` jamal
2004-07-29 22:54 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040723.110007.27520072.yoshfuji@linux-ipv6.org \
--to=yoshfuji@linux-ipv6.org \
--cc=arekm@pld-linux.org \
--cc=davem@redhat.com \
--cc=hadi@znyx.com \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).