From: Masahide Nakamura <nakam@linux-ipv6.org>
To: <davem@redhat.com>, netdev@oss.sgi.com
Subject: [PATCH]Fix adding SA through netlink(xfrm_user)
Date: Thu, 29 Jul 2004 00:10:58 +0900 [thread overview]
Message-ID: <20040729001058.48cd1791@localhost> (raw)
Hello,
When adding IPsec SA with PF_KEY (pfkey_add()),
xfrm_probe_algs() is called to make all algorithms valid.
However, it is missing to call it with netlink (xfrm_user) case and
it causes xfrm_aalg_get_byname() return NULL even if the name of
algorithm seems to be correct.
The patch fixes it and is against 2.6.7. Please apply it.
Index: linux26/net/xfrm/xfrm_user.c
===================================================================
RCS file: /cvsroot/usagi/usagi/kernel/linux26/net/xfrm/xfrm_user.c,v
retrieving revision 1.1.1.13
diff -u -r1.1.1.13 xfrm_user.c
--- linux26/net/xfrm/xfrm_user.c 3 Apr 2004 05:52:43 -0000 1.1.1.13
+++ linux26/net/xfrm/xfrm_user.c 28 Jul 2004 14:26:21 -0000
@@ -258,6 +258,8 @@
if (err)
return err;
+ xfrm_probe_algs();
+
x = xfrm_state_construct(p, (struct rtattr **) xfrma, &err);
if (!x)
return err;
--
Masahide NAKAMURA
next reply other threads:[~2004-07-28 15:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-28 15:10 Masahide Nakamura [this message]
2004-07-28 15:41 ` [PATCH]Fix adding SA through netlink(xfrm_user) James Morris
2004-07-29 2:07 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040729001058.48cd1791@localhost \
--to=nakam@linux-ipv6.org \
--cc=davem@redhat.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).