* [PATCH 2.6] convert ROSE to use module_param
@ 2004-07-29 18:35 Stephen Hemminger
2004-07-29 23:01 ` David S. Miller
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2004-07-29 18:35 UTC (permalink / raw)
To: David S. Miller, ralf; +Cc: netdev, linux-hams
Switch to module_param and the hash list can be local.
Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
diff -Nru a/net/rose/af_rose.c b/net/rose/af_rose.c
--- a/net/rose/af_rose.c 2004-07-23 13:33:31 -07:00
+++ b/net/rose/af_rose.c 2004-07-23 13:33:31 -07:00
@@ -11,6 +11,7 @@
*/
#include <linux/config.h>
#include <linux/module.h>
+#include <linux/moduleparam.h>
#include <linux/init.h>
#include <linux/errno.h>
#include <linux/types.h>
@@ -57,7 +58,7 @@
int sysctl_rose_maximum_vcs = ROSE_DEFAULT_MAXVC;
int sysctl_rose_window_size = ROSE_DEFAULT_WINDOW_SIZE;
-HLIST_HEAD(rose_list);
+static HLIST_HEAD(rose_list);
spinlock_t rose_list_lock = SPIN_LOCK_UNLOCKED;
static struct proto_ops rose_proto_ops;
@@ -1550,7 +1551,7 @@
}
module_init(rose_proto_init);
-MODULE_PARM(rose_ndevs, "i");
+module_param(rose_ndevs, int, 0);
MODULE_PARM_DESC(rose_ndevs, "number of ROSE devices");
MODULE_AUTHOR("Jonathan Naylor G4KLX <g4klx@g4klx.demon.co.uk>");
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 2.6] convert ROSE to use module_param
2004-07-29 18:35 [PATCH 2.6] convert ROSE to use module_param Stephen Hemminger
@ 2004-07-29 23:01 ` David S. Miller
0 siblings, 0 replies; 2+ messages in thread
From: David S. Miller @ 2004-07-29 23:01 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: ralf, netdev, linux-hams
On Thu, 29 Jul 2004 11:35:22 -0700
Stephen Hemminger <shemminger@osdl.org> wrote:
> Switch to module_param and the hash list can be local.
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-07-29 23:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-07-29 18:35 [PATCH 2.6] convert ROSE to use module_param Stephen Hemminger
2004-07-29 23:01 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).