From: bert hubert <ahu@ds9a.nl>
To: Herbert Xu <herbert@gondor.apana.org.au>, netdev@oss.sgi.com
Cc: davem@redhat.com
Subject: [IPSEC PATCH] missing break in UDP decap code Re: (udp-en/decap broken in 2.6.8-rc2?) Re: ipsec, nat-t, iproute2?
Date: Sat, 31 Jul 2004 15:08:53 +0200 [thread overview]
Message-ID: <20040731130853.GA30481@outpost.ds9a.nl> (raw)
In-Reply-To: <20040731121828.GA29497@outpost.ds9a.nl>
> I've tried it both ways, both don't work. I should have mentioned that.
Against 2.6.8-rc2, neatly solves the problem. The missing break causes the
packet to be tested against both encapsulation types, one will always fail.
--- linux-2.6.8-rc2/net/ipv4/udp.c~orig 2004-07-31 15:04:56.000000000 +0200
+++ linux-2.6.8-rc2/net/ipv4/udp.c 2004-07-31 15:05:19.000000000 +0200
@@ -975,7 +975,7 @@
} else
/* Must be an IKE packet.. pass it through */
return 1;
-
+ break;
case UDP_ENCAP_ESPINUDP_NON_IKE:
/* Check if this is a keepalive packet. If so, eat it. */
if (len == 1 && udpdata[0] == 0xff) {
@@ -988,6 +988,7 @@
} else
/* Must be an IKE packet.. pass it through */
return 1;
+ break;
}
/* At this point we are sure that this is an ESPinUDP packet,
--
http://www.PowerDNS.com Open source, database driven DNS Software
http://lartc.org Linux Advanced Routing & Traffic Control HOWTO
next prev parent reply other threads:[~2004-07-31 13:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-30 17:07 ipsec, nat-t, iproute2? bert hubert
2004-07-30 18:12 ` bert hubert
2004-07-30 18:55 ` James Morris
2004-07-30 22:38 ` (udp-en/decap broken in 2.6.8-rc2?) " bert hubert
2004-07-31 7:50 ` Herbert Xu
2004-07-31 8:34 ` bert hubert
2004-07-31 10:32 ` Herbert Xu
2004-07-31 11:20 ` bert hubert
2004-07-31 11:52 ` Herbert Xu
2004-07-31 12:18 ` bert hubert
2004-07-31 13:08 ` bert hubert [this message]
2004-07-31 19:32 ` [IPSEC PATCH] missing break in UDP decap code " Herbert Xu
2004-08-01 6:53 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040731130853.GA30481@outpost.ds9a.nl \
--to=ahu@ds9a.nl \
--cc=davem@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).