* ipsec, nat-t, iproute2? @ 2004-07-30 17:07 bert hubert 2004-07-30 18:12 ` bert hubert 2004-07-30 18:55 ` James Morris 0 siblings, 2 replies; 13+ messages in thread From: bert hubert @ 2004-07-30 17:07 UTC (permalink / raw) To: netdev Hi people, I'm once again trying to get a hang of the state of ipsec in linux, and I have some questions. 1) One can configure ipsec over netlink (XFRM_USER), is this the preferred interface? Is it documented somehwere, or is there some source which uses this interface? Alternatively, is PFKEY considered deprecated? 2) I hear people are working on iproute so it can use XFRM_USER, is this code available somewhere? 3) NAT-Traversal, how does one set this up either using setkey, iproute2+stuff, or XFRM_USER? Is it supposed to work right now? Is NAT-T 'UDP_ENCAP_ESPINUDP'? Thanks. What I'll figure out from these questions I'll document. -- http://www.PowerDNS.com Open source, database driven DNS Software http://lartc.org Linux Advanced Routing & Traffic Control HOWTO ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: ipsec, nat-t, iproute2? 2004-07-30 17:07 ipsec, nat-t, iproute2? bert hubert @ 2004-07-30 18:12 ` bert hubert 2004-07-30 18:55 ` James Morris 1 sibling, 0 replies; 13+ messages in thread From: bert hubert @ 2004-07-30 18:12 UTC (permalink / raw) To: netdev On Fri, Jul 30, 2004 at 07:07:26PM +0200, bert hubert wrote: > 2) I hear people are working on iproute so it can use XFRM_USER, is this > code available somewhere? Ok, this is rather embarassing, turns out that this is all discussed on my own LARTC mailinglist. I should read it every once in a while. The code is in the bitkeeper described on http://developer.osdl.org/dev/iproute2/ > 3) NAT-Traversal, how does one set this up either using setkey, > iproute2+stuff, or XFRM_USER? Is it supposed to work right now? > Is NAT-T 'UDP_ENCAP_ESPINUDP'? Sadly, this code does not yet do encap. *Swan appears to have support for this over XFRM_USER, currently reading it. -- http://www.PowerDNS.com Open source, database driven DNS Software http://lartc.org Linux Advanced Routing & Traffic Control HOWTO ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: ipsec, nat-t, iproute2? 2004-07-30 17:07 ipsec, nat-t, iproute2? bert hubert 2004-07-30 18:12 ` bert hubert @ 2004-07-30 18:55 ` James Morris 2004-07-30 22:38 ` (udp-en/decap broken in 2.6.8-rc2?) " bert hubert 1 sibling, 1 reply; 13+ messages in thread From: James Morris @ 2004-07-30 18:55 UTC (permalink / raw) To: bert hubert; +Cc: netdev On Fri, 30 Jul 2004, bert hubert wrote: > 1) One can configure ipsec over netlink (XFRM_USER), is this the preferred > interface? Is it documented somehwere, or is there some source which uses > this interface? Alternatively, is PFKEY considered deprecated? PF_KEY is not deprecated, it's an IETF standard and required for compliance & compatibility. XFRM_USER is simply the native Linux interface. - James -- James Morris <jmorris@redhat.com> ^ permalink raw reply [flat|nested] 13+ messages in thread
* (udp-en/decap broken in 2.6.8-rc2?) Re: ipsec, nat-t, iproute2? 2004-07-30 18:55 ` James Morris @ 2004-07-30 22:38 ` bert hubert 2004-07-31 7:50 ` Herbert Xu 0 siblings, 1 reply; 13+ messages in thread From: bert hubert @ 2004-07-30 22:38 UTC (permalink / raw) To: James Morris; +Cc: netdev On Fri, Jul 30, 2004 at 02:55:19PM -0400, James Morris wrote: > PF_KEY is not deprecated, it's an IETF standard and required for > compliance & compatibility. XFRM_USER is simply the native Linux > interface. Ok, thanks. I've gotten to the point where I can configure nat-t over XFRM, however, I find that it does not work. The encoding looks fine but the receiving side does not appear to listen: 00:34:09.491228 IP 192.168.1.4.4500 > 10.0.0.3.4500: UDP, length: 88 00:34:09.492290 IP 10.0.0.3 > 192.168.1.4: icmp 124: 10.0.0.3 udp port 4500 unreachable 00:34:10.492245 IP 192.168.1.4.4500 > 10.0.0.3.4500: UDP, length: 88 00:34:10.493332 IP 10.0.0.3 > 192.168.1.4: icmp 124: 10.0.0.3 udp port 4500 unreachable 00:34:11.493090 IP 192.168.1.4.4500 > 10.0.0.3.4500: UDP, length: 88 00:34:11.494337 IP 10.0.0.3 > 192.168.1.4: icmp 124: 10.0.0.3 udp port 4500 unreachable This is the setkey configuration I use on 10.0.0.3: #!/usr/sbin/setkey -f flush; spdflush; add 192.168.1.4 10.0.0.3 esp-udp 10.0.0.3 34501 -E 3des-cbc "123456789012123456789012"; spdadd 192.168.1.4 10.0.0.3 icmp -P in ipsec esp/transport//require; And on the other side (192.168.1.4): #!/usr/sbin/setkey -f flush; spdflush; add 192.168.1.4 10.0.0.3 esp-udp 192.168.1.4 34501 -E 3des-cbc "123456789012123456789012"; spdadd 192.168.1.4 10.0.0.3 icmp -P out ipsec esp/transport//require; I've toyed a bit with the IP address after esp-udp, not sure what it does. Thanks. -- http://www.PowerDNS.com Open source, database driven DNS Software http://lartc.org Linux Advanced Routing & Traffic Control HOWTO ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: (udp-en/decap broken in 2.6.8-rc2?) Re: ipsec, nat-t, iproute2? 2004-07-30 22:38 ` (udp-en/decap broken in 2.6.8-rc2?) " bert hubert @ 2004-07-31 7:50 ` Herbert Xu 2004-07-31 8:34 ` bert hubert 0 siblings, 1 reply; 13+ messages in thread From: Herbert Xu @ 2004-07-31 7:50 UTC (permalink / raw) To: bert hubert; +Cc: jmorris, netdev bert hubert <ahu@ds9a.nl> wrote: > > The encoding looks fine but the receiving side does not appear to listen: > > 00:34:09.491228 IP 192.168.1.4.4500 > 10.0.0.3.4500: UDP, length: 88 > 00:34:09.492290 IP 10.0.0.3 > 192.168.1.4: icmp 124: 10.0.0.3 udp port 4500 > unreachable You need to have someone open a socket on port 4500 and do the appropriate setsockopt() on it. > This is the setkey configuration I use on 10.0.0.3: Any reason why you aren't using automatic keying? -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: (udp-en/decap broken in 2.6.8-rc2?) Re: ipsec, nat-t, iproute2? 2004-07-31 7:50 ` Herbert Xu @ 2004-07-31 8:34 ` bert hubert 2004-07-31 10:32 ` Herbert Xu 0 siblings, 1 reply; 13+ messages in thread From: bert hubert @ 2004-07-31 8:34 UTC (permalink / raw) To: Herbert Xu; +Cc: jmorris, netdev On Sat, Jul 31, 2004 at 05:50:05PM +1000, Herbert Xu wrote: > You need to have someone open a socket on port 4500 and do the > appropriate setsockopt() on it. Would this be: #define UDP_ESPINUDP 100, known in the kernel as UDP_ENCAP? Does the socket need to be kept open after the setsockopt? Do the encapsulated packets reach userspace? The right way to do this is probably to first get a socket, set it to UDP_ENCAP, and only then try to negotiate an SA, using the port number assigned previously? > > This is the setkey configuration I use on 10.0.0.3: > > Any reason why you aren't using automatic keying? I'm trying to figure out how this stuff works with an eye on documenting it. So far I haven't been able to get openswan to do nat-t, hence I've been trying to do this from the ground up. Thanks. -- http://www.PowerDNS.com Open source, database driven DNS Software http://lartc.org Linux Advanced Routing & Traffic Control HOWTO ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: (udp-en/decap broken in 2.6.8-rc2?) Re: ipsec, nat-t, iproute2? 2004-07-31 8:34 ` bert hubert @ 2004-07-31 10:32 ` Herbert Xu 2004-07-31 11:20 ` bert hubert 0 siblings, 1 reply; 13+ messages in thread From: Herbert Xu @ 2004-07-31 10:32 UTC (permalink / raw) To: bert hubert; +Cc: herbert, jmorris, netdev bert hubert <ahu@ds9a.nl> wrote: > > Would this be: > #define UDP_ESPINUDP 100, known in the kernel as UDP_ENCAP? Correct. > Does the socket need to be kept open after the setsockopt? Do the Yes. > encapsulated packets reach userspace? No. > The right way to do this is probably to first get a socket, set it to > UDP_ENCAP, and only then try to negotiate an SA, using the port number > assigned previously? Theoretically you can use another port if you're the initiator, but the draft document requires you to use port 4500. > I'm trying to figure out how this stuff works with an eye on documenting it. > So far I haven't been able to get openswan to do nat-t, hence I've been > trying to do this from the ground up. There is a NAT-T bug in Opeswan 2.1.* which was recently fixed. Here is the patch. In future please ask on users@lists.openswan.org. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- Index: programs/pluto/server.c =================================================================== RCS file: /public/cvs/openswan-2/programs/pluto/server.c,v retrieving revision 1.97 diff -u -r1.97 server.c --- programs/pluto/server.c 2 Jun 2004 12:42:50 -0000 1.97 +++ programs/pluto/server.c 22 Jul 2004 03:34:50 -0000 @@ -523,6 +523,51 @@ } #endif +#if defined(linux) && defined(KERNEL26_SUPPORT) + if (!no_klips && kernel_ops->type == KERNEL_TYPE_LINUX) + { + struct sadb_x_policy policy; + int level, opt; + + policy.sadb_x_policy_len = sizeof(policy) / IPSEC_PFKEYv2_ALIGN; + policy.sadb_x_policy_exttype = SADB_X_EXT_POLICY; + policy.sadb_x_policy_type = IPSEC_POLICY_BYPASS; + policy.sadb_x_policy_dir = IPSEC_DIR_INBOUND; + policy.sadb_x_policy_reserved = 0; + policy.sadb_x_policy_id = 0; + policy.sadb_x_policy_reserved2 = 0; + + if (addrtypeof(&ifp->addr) == AF_INET6) + { + level = IPPROTO_IPV6; + opt = IPV6_IPSEC_POLICY; + } + else + { + level = IPPROTO_IP; + opt = IP_IPSEC_POLICY; + } + + if (setsockopt(fd, level, opt + , &policy, sizeof(policy)) < 0) + { + log_errno((e, "setsockopt IPSEC_POLICY in process_raw_ifaces()")); + close(fd); + return -1; + } + + policy.sadb_x_policy_dir = IPSEC_DIR_OUTBOUND; + + if (setsockopt(fd, level, opt + , &policy, sizeof(policy)) < 0) + { + log_errno((e, "setsockopt IPSEC_POLICY in process_raw_ifaces()")); + close(fd); + return -1; + } + } +#endif + setportof(htons(port), &ifp->addr); if (bind(fd, sockaddrof(&ifp->addr), sockaddrlenof(&ifp->addr)) < 0) { @@ -659,13 +704,10 @@ if (q == NULL) { /* matches nothing -- create a new entry */ - int fd = socket(addrtypeof(&ifp->addr), SOCK_DGRAM, IPPROTO_UDP); + int fd = create_socket(ifp, v->name, pluto_port); if (fd < 0) - { - log_errno((e, "socket() in process_raw_ifaces()")); break; - } #ifdef NAT_TRAVERSAL if (nat_traversal_support_non_ike) @@ -673,96 +715,6 @@ nat_traversal_espinudp_socket(fd, ESPINUDP_WITH_NON_IKE); } #endif - if (fcntl(fd, F_SETFD, FD_CLOEXEC) == -1) - { - log_errno((e, "fcntl(,, FD_CLOEXEC) in process_raw_ifaces()")); - break; - } - - if (setsockopt(fd, SOL_SOCKET, SO_REUSEADDR - , (const void *)&on, sizeof(on)) < 0) - { - log_errno((e, "setsockopt SO_REUSEADDR in process_raw_ifaces()")); - break; - } - - /* To improve error reporting. See ip(7). */ -#if defined(IP_RECVERR) && defined(MSG_ERRQUEUE) - if (setsockopt(fd, SOL_IP, IP_RECVERR - , (const void *)&on, sizeof(on)) < 0) - { - log_errno((e, "setsockopt IP_RECVERR in process_raw_ifaces()")); - break; - } -#endif - - /* With IPv6, there is no fragmentation after - * it leaves our interface. PMTU discovery - * is mandatory but doesn't work well with IKE (why?). - * So we must set the IPV6_USE_MIN_MTU option. - * See draft-ietf-ipngwg-rfc2292bis-01.txt 11.1 - */ -#ifdef IPV6_USE_MIN_MTU /* YUCK: not always defined */ - if (addrtypeof(&ifp->addr) == AF_INET6 - && setsockopt(fd, SOL_SOCKET, IPV6_USE_MIN_MTU - , (const void *)&on, sizeof(on)) < 0) - { - log_errno((e, "setsockopt IPV6_USE_MIN_MTU in process_raw_ifaces()")); - break; - } -#endif - -#if defined(linux) && defined(KERNEL26_SUPPORT) - if (!no_klips && kernel_ops->type == KERNEL_TYPE_LINUX) - { - struct sadb_x_policy policy; - int level, opt; - - policy.sadb_x_policy_len = sizeof(policy) / IPSEC_PFKEYv2_ALIGN; - policy.sadb_x_policy_exttype = SADB_X_EXT_POLICY; - policy.sadb_x_policy_type = IPSEC_POLICY_BYPASS; - policy.sadb_x_policy_dir = IPSEC_DIR_INBOUND; - policy.sadb_x_policy_reserved = 0; - policy.sadb_x_policy_id = 0; - policy.sadb_x_policy_reserved2 = 0; - - if (addrtypeof(&ifp->addr) == AF_INET6) - { - level = IPPROTO_IPV6; - opt = IPV6_IPSEC_POLICY; - } - else - { - level = IPPROTO_IP; - opt = IP_IPSEC_POLICY; - } - - if (setsockopt(fd, level, opt - , &policy, sizeof(policy)) < 0) - { - log_errno((e, "setsockopt IPSEC_POLICY in process_raw_ifaces()")); - break; - } - - policy.sadb_x_policy_dir = IPSEC_DIR_OUTBOUND; - - if (setsockopt(fd, level, opt - , &policy, sizeof(policy)) < 0) - { - log_errno((e, "setsockopt IPSEC_POLICY in process_raw_ifaces()")); - break; - } - } -#endif - - setportof(htons(pluto_port), &ifp->addr); - if (bind(fd, sockaddrof(&ifp->addr), sockaddrlenof(&ifp->addr)) < 0) - { - log_errno((e, "bind() for %s/%s %s:%u in process_raw_ifaces()" - , ifp->name, v->name - , ip_str(&ifp->addr), (unsigned) pluto_port)); - break; - } q = alloc_thing(struct iface, "struct iface"); q->rname = clone_str(ifp->name, "real device name"); ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: (udp-en/decap broken in 2.6.8-rc2?) Re: ipsec, nat-t, iproute2? 2004-07-31 10:32 ` Herbert Xu @ 2004-07-31 11:20 ` bert hubert 2004-07-31 11:52 ` Herbert Xu 0 siblings, 1 reply; 13+ messages in thread From: bert hubert @ 2004-07-31 11:20 UTC (permalink / raw) To: Herbert Xu; +Cc: jmorris, netdev On Sat, Jul 31, 2004 at 08:32:07PM +1000, Herbert Xu wrote: > > encapsulated packets reach userspace? > > No. socket(PF_INET, SOCK_DGRAM, IPPROTO_UDP) = 3 setsockopt(3, SOL_SOCKET, SO_REUSEADDR, [1], 4) = 0 bind(3, {sa_family=AF_INET, sin_port=htons(4500), sin_addr=inet_addr("10.0.0.3")}, 16) = 0 setsockopt(3, SOL_UDP, 100, [1], 4) = 0 read(3, "\0\0\206\305\0\0\f\311\27\263\3379\313z\377T\310\6\25\217"..., 1024) = 104 I do see packets coming in on 2.6.8-rc2 and tethereal verifies that the packets at least appear to be ESP: Internet Protocol, Src Addr: 192.168.1.4 (192.168.1.4), Dst Addr: 10.0.0.3 (10.0.0.3) Version: 4 Header length: 20 bytes Differentiated Services Field: 0x00 (DSCP 0x00: Default; ECN: 0x00) 0000 00.. = Differentiated Services Codepoint: Default (0x00) .... ..0. = ECN-Capable Transport (ECT): 0 .... ...0 = ECN-CE: 0 Total Length: 132 Identification: 0x00f0 (240) Flags: 0x04 (Don't Fragment) 0... = Reserved bit: Not set .1.. = Don't fragment: Set ..0. = More fragments: Not set Fragment offset: 0 Time to live: 64 Protocol: UDP (0x11) Header checksum: 0x6dca (correct) Source: 192.168.1.4 (192.168.1.4) Destination: 10.0.0.3 (10.0.0.3) User Datagram Protocol, Src Port: 4500 (4500), Dst Port: 4500 (4500) Source port: 4500 (4500) Destination port: 4500 (4500) Length: 112 Checksum: 0x0000 (none) UDP Encapsulation of IPsec Packets Encapsulating Security Payload SPI: 0x000086c5 Sequence: 4116 Data (96 bytes) I'm trying to reverse engineer the code out there but can't find other things I need to do to get this to work - right now the kernel does not see the ESP packets, but passes them to userspace. I have this SA in place on the receiving end: 192.168.1.4[4500] 10.0.0.3[4500] esp-udp mode=transport spi=34501(0x000086c5) reqid=0(0x00000000) E: aes-cbc 31323334 35363738 39303132 31323334 35363738 39303132 seq=0x00000000 replay=0 flags=0x00000000 state=mature created: Jul 31 13:12:09 2004 current: Jul 31 13:12:13 2004 diff: 4(s) hard: 0(s) soft: 0(s) last: hard: 0(s) soft: 0(s) current: 0(bytes) hard: 0(bytes) soft: 0(bytes) allocated: 0 hard: 0 soft: 0 sadb_seq=0 pid=595 refcnt=0 Note how the SPI matches with what tethereal sees. And this policy on 10.0.0.3. 192.168.1.4[any] 10.0.0.3[any] icmp in ipsec esp/transport//require created: Jul 31 13:14:22 2004 lastused: lifetime: 0(s) validtime: 0(s) spid=16 seq=0 pid=659 refcnt=1 Any further ideas? -- http://www.PowerDNS.com Open source, database driven DNS Software http://lartc.org Linux Advanced Routing & Traffic Control HOWTO ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: (udp-en/decap broken in 2.6.8-rc2?) Re: ipsec, nat-t, iproute2? 2004-07-31 11:20 ` bert hubert @ 2004-07-31 11:52 ` Herbert Xu 2004-07-31 12:18 ` bert hubert 0 siblings, 1 reply; 13+ messages in thread From: Herbert Xu @ 2004-07-31 11:52 UTC (permalink / raw) To: bert hubert, jmorris, netdev On Sat, Jul 31, 2004 at 01:20:49PM +0200, bert hubert wrote: > > setsockopt(3, SOL_UDP, 100, [1], 4) = 0 You chose NON_IKE. > read(3, "\0\0\206\305\0\0\f\311\27\263\3379\313z\377T\310\6\25\217"..., 1024) = 104 This packet is NON_ESP, aka UDP_ENCAP_ESPINUDP. > Any further ideas? Either change the receiving end to using NON_ESP or change the sender to use NON_IKE. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: (udp-en/decap broken in 2.6.8-rc2?) Re: ipsec, nat-t, iproute2? 2004-07-31 11:52 ` Herbert Xu @ 2004-07-31 12:18 ` bert hubert 2004-07-31 13:08 ` [IPSEC PATCH] missing break in UDP decap code " bert hubert 0 siblings, 1 reply; 13+ messages in thread From: bert hubert @ 2004-07-31 12:18 UTC (permalink / raw) To: Herbert Xu; +Cc: netdev [-- Attachment #1: Type: text/plain, Size: 661 bytes --] On Sat, Jul 31, 2004 at 09:52:30PM +1000, Herbert Xu wrote: > On Sat, Jul 31, 2004 at 01:20:49PM +0200, bert hubert wrote: > > > > setsockopt(3, SOL_UDP, 100, [1], 4) = 0 > > You chose NON_IKE. I've tried it both ways, both don't work. I should have mentioned that. I've attached the code that tries to setup the receiving end so things work. It is in c++, I hope that does not offend too many people. g++ udpencap.cc -o udpencap You can strace it to see what it is doing in any case. Thanks again. -- http://www.PowerDNS.com Open source, database driven DNS Software http://lartc.org Linux Advanced Routing & Traffic Control HOWTO [-- Attachment #2: udpencap.tar.gz --] [-- Type: application/octet-stream, Size: 3209 bytes --] ^ permalink raw reply [flat|nested] 13+ messages in thread
* [IPSEC PATCH] missing break in UDP decap code Re: (udp-en/decap broken in 2.6.8-rc2?) Re: ipsec, nat-t, iproute2? 2004-07-31 12:18 ` bert hubert @ 2004-07-31 13:08 ` bert hubert 2004-07-31 19:32 ` Herbert Xu 0 siblings, 1 reply; 13+ messages in thread From: bert hubert @ 2004-07-31 13:08 UTC (permalink / raw) To: Herbert Xu, netdev; +Cc: davem > I've tried it both ways, both don't work. I should have mentioned that. Against 2.6.8-rc2, neatly solves the problem. The missing break causes the packet to be tested against both encapsulation types, one will always fail. --- linux-2.6.8-rc2/net/ipv4/udp.c~orig 2004-07-31 15:04:56.000000000 +0200 +++ linux-2.6.8-rc2/net/ipv4/udp.c 2004-07-31 15:05:19.000000000 +0200 @@ -975,7 +975,7 @@ } else /* Must be an IKE packet.. pass it through */ return 1; - + break; case UDP_ENCAP_ESPINUDP_NON_IKE: /* Check if this is a keepalive packet. If so, eat it. */ if (len == 1 && udpdata[0] == 0xff) { @@ -988,6 +988,7 @@ } else /* Must be an IKE packet.. pass it through */ return 1; + break; } /* At this point we are sure that this is an ESPinUDP packet, -- http://www.PowerDNS.com Open source, database driven DNS Software http://lartc.org Linux Advanced Routing & Traffic Control HOWTO ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [IPSEC PATCH] missing break in UDP decap code Re: (udp-en/decap broken in 2.6.8-rc2?) Re: ipsec, nat-t, iproute2? 2004-07-31 13:08 ` [IPSEC PATCH] missing break in UDP decap code " bert hubert @ 2004-07-31 19:32 ` Herbert Xu 2004-08-01 6:53 ` David S. Miller 0 siblings, 1 reply; 13+ messages in thread From: Herbert Xu @ 2004-07-31 19:32 UTC (permalink / raw) To: bert hubert, netdev, davem On Sat, Jul 31, 2004 at 03:08:53PM +0200, bert hubert wrote: > > Against 2.6.8-rc2, neatly solves the problem. The missing break causes the > packet to be tested against both encapsulation types, one will always fail. Sorry, that was my fault. Dave, please apply his patch to fix NON_ESP reception. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [IPSEC PATCH] missing break in UDP decap code Re: (udp-en/decap broken in 2.6.8-rc2?) Re: ipsec, nat-t, iproute2? 2004-07-31 19:32 ` Herbert Xu @ 2004-08-01 6:53 ` David S. Miller 0 siblings, 0 replies; 13+ messages in thread From: David S. Miller @ 2004-08-01 6:53 UTC (permalink / raw) To: Herbert Xu; +Cc: ahu, netdev On Sun, 1 Aug 2004 05:32:04 +1000 Herbert Xu <herbert@gondor.apana.org.au> wrote: > On Sat, Jul 31, 2004 at 03:08:53PM +0200, bert hubert wrote: > > > > Against 2.6.8-rc2, neatly solves the problem. The missing break causes the > > packet to be tested against both encapsulation types, one will always fail. > > Sorry, that was my fault. > > Dave, please apply his patch to fix NON_ESP reception. Done, thanks guys. ^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2004-08-01 6:53 UTC | newest] Thread overview: 13+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2004-07-30 17:07 ipsec, nat-t, iproute2? bert hubert 2004-07-30 18:12 ` bert hubert 2004-07-30 18:55 ` James Morris 2004-07-30 22:38 ` (udp-en/decap broken in 2.6.8-rc2?) " bert hubert 2004-07-31 7:50 ` Herbert Xu 2004-07-31 8:34 ` bert hubert 2004-07-31 10:32 ` Herbert Xu 2004-07-31 11:20 ` bert hubert 2004-07-31 11:52 ` Herbert Xu 2004-07-31 12:18 ` bert hubert 2004-07-31 13:08 ` [IPSEC PATCH] missing break in UDP decap code " bert hubert 2004-07-31 19:32 ` Herbert Xu 2004-08-01 6:53 ` David S. Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).