From: "YOSHIFUJI Hideaki / 吉藤英明" <yoshfuji@linux-ipv6.org>
To: suckfish@ihug.co.nz
Cc: davem@redhat.com, pekkas@netcore.fi,
linux-kernel@vger.kernel.org, yoshfuji@linux-ipv6.org,
netdev@oss.sgi.com
Subject: Re: [PATCH] Trivial ipv6 fix.
Date: Mon, 02 Aug 2004 06:59:40 -0700 (PDT) [thread overview]
Message-ID: <20040802.065940.86004622.yoshfuji@linux-ipv6.org> (raw)
In-Reply-To: <1091434328.16469.5.camel@localhost.localdomain>
In article <1091434328.16469.5.camel@localhost.localdomain> (at Mon, 02 Aug 2004 20:12:08 +1200), Ralph Loader <suckfish@ihug.co.nz> says:
> ipv6_addr_hash doesn't do what it's comment says. The comment was
> probably what was intended, not that it'll make much difference in
> practice.
Oops, David, please apply this.
> Signed-off-by: Ralph Loader <suckfish@ihug.co.nz>
Signed-off-by: Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>
===== include/net/addrconf.h 1.17 vs edited =====
--- 1.17/include/net/addrconf.h 2004-07-29 02:00:50 +09:00
+++ edited/include/net/addrconf.h 2004-08-02 22:57:38 +09:00
@@ -178,8 +178,8 @@
* This will include the IEEE address token on links that support it.
*/
- word = addr->s6_addr[2] ^ addr->s6_addr32[3];
- word ^= (word>>16);
+ word = addr->s6_addr32[2] ^ addr->s6_addr32[3];
+ word ^= (word >> 16);
word ^= (word >> 8);
return ((word ^ (word >> 4)) & 0x0f);
--
Hideaki YOSHIFUJI @ USAGI Project <yoshfuji@linux-ipv6.org>
GPG FP: 9022 65EB 1ECF 3AD1 0BDF 80D8 4807 F894 E062 0EEA
next parent reply other threads:[~2004-08-02 13:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1091434328.16469.5.camel@localhost.localdomain>
2004-08-02 13:59 ` YOSHIFUJI Hideaki / 吉藤英明 [this message]
2004-08-03 0:08 ` [PATCH] Trivial ipv6 fix David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040802.065940.86004622.yoshfuji@linux-ipv6.org \
--to=yoshfuji@linux-ipv6.org \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=pekkas@netcore.fi \
--cc=suckfish@ihug.co.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).