netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH] Trivial ipv6 fix.
       [not found] <1091434328.16469.5.camel@localhost.localdomain>
@ 2004-08-02 13:59 ` YOSHIFUJI Hideaki / 吉藤英明
  2004-08-03  0:08   ` David S. Miller
  0 siblings, 1 reply; 2+ messages in thread
From: YOSHIFUJI Hideaki / 吉藤英明 @ 2004-08-02 13:59 UTC (permalink / raw)
  To: suckfish; +Cc: davem, pekkas, linux-kernel, yoshfuji, netdev

In article <1091434328.16469.5.camel@localhost.localdomain> (at Mon, 02 Aug 2004 20:12:08 +1200), Ralph Loader <suckfish@ihug.co.nz> says:

> ipv6_addr_hash doesn't do what it's comment says.  The comment was
> probably what was intended, not that it'll make much difference in
> practice.

Oops, David, please apply this.

> Signed-off-by: Ralph Loader <suckfish@ihug.co.nz>
Signed-off-by: Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>

===== include/net/addrconf.h 1.17 vs edited =====
--- 1.17/include/net/addrconf.h	2004-07-29 02:00:50 +09:00
+++ edited/include/net/addrconf.h	2004-08-02 22:57:38 +09:00
@@ -178,8 +178,8 @@
 	 * This will include the IEEE address token on links that support it.
 	 */
 
-	word = addr->s6_addr[2] ^ addr->s6_addr32[3];
-	word  ^= (word>>16);
+	word = addr->s6_addr32[2] ^ addr->s6_addr32[3];
+	word ^= (word >> 16);
 	word ^= (word >> 8);
 
 	return ((word ^ (word >> 4)) & 0x0f);

-- 
Hideaki YOSHIFUJI @ USAGI Project <yoshfuji@linux-ipv6.org>
GPG FP: 9022 65EB 1ECF 3AD1 0BDF  80D8 4807 F894 E062 0EEA

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Trivial ipv6 fix.
  2004-08-02 13:59 ` [PATCH] Trivial ipv6 fix YOSHIFUJI Hideaki / 吉藤英明
@ 2004-08-03  0:08   ` David S. Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David S. Miller @ 2004-08-03  0:08 UTC (permalink / raw)
  To: yoshfuji; +Cc: suckfish, pekkas, linux-kernel, yoshfuji, netdev

On Mon, 02 Aug 2004 06:59:40 -0700 (PDT)
YOSHIFUJI Hideaki / ^[$B5HF#1QL@^[(B <yoshfuji@linux-ipv6.org> wrote:

> In article <1091434328.16469.5.camel@localhost.localdomain> (at Mon, 02 Aug 2004 20:12:08 +1200), Ralph Loader <suckfish@ihug.co.nz> says:
> 
> > ipv6_addr_hash doesn't do what it's comment says.  The comment was
> > probably what was intended, not that it'll make much difference in
> > practice.
> 
> Oops, David, please apply this.

Done, thanks guys.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-08-03  0:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <1091434328.16469.5.camel@localhost.localdomain>
2004-08-02 13:59 ` [PATCH] Trivial ipv6 fix YOSHIFUJI Hideaki / 吉藤英明
2004-08-03  0:08   ` David S. Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).