From: "David S. Miller" <davem@redhat.com>
To: Patrick McHardy <kaber@trash.net>
Cc: netdev@oss.sgi.com
Subject: Re: [PATCH 2.6 1/5]: Fix locking in __qdisc_destroy rcu-callback
Date: Wed, 4 Aug 2004 09:33:28 -0700 [thread overview]
Message-ID: <20040804093328.4ee56d30.davem@redhat.com> (raw)
In-Reply-To: <410FAD44.7020503@trash.net>
On Tue, 03 Aug 2004 17:20:36 +0200
Patrick McHardy <kaber@trash.net> wrote:
> The __qdisc_destroy rcu-callback doesn't do any locking when calling
> ops->reset and ops->destroy. qdisc_destroy is often called from both
> of these functions and it changes dev->qdisc_list. This patch adds proper
> locking to __qdisc_destroy. Unfortunately when using qdisc_tree_lock in
> process context we now also need to disable local bh's to avoid beeing
> interrupted by the rcu-callback. I'm not sure if RCU callback can be
> scheduled while the kernel is running in process context, so this may
> be unneccessary.
RCU callbacks run via tasklets, and thus in softirq context,
thus your locking changes to _bh() are indeed necessary.
I will apply this patch, thanks Patrick.
next prev parent reply other threads:[~2004-08-04 16:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-03 15:20 [PATCH 2.6 1/5]: Fix locking in __qdisc_destroy rcu-callback Patrick McHardy
2004-08-04 16:33 ` David S. Miller [this message]
2004-08-04 19:53 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040804093328.4ee56d30.davem@redhat.com \
--to=davem@redhat.com \
--cc=kaber@trash.net \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).