From: "David S. Miller" <davem@redhat.com>
To: Patrick McHardy <kaber@trash.net>
Cc: netdev@oss.sgi.com
Subject: Re: [PATCH 2.6 3/5]: Use double-linked list for dev->qdisc_list
Date: Wed, 4 Aug 2004 09:43:08 -0700 [thread overview]
Message-ID: <20040804094308.606f79bd.davem@redhat.com> (raw)
In-Reply-To: <410FAE42.2050909@trash.net>
On Tue, 03 Aug 2004 17:24:50 +0200
Patrick McHardy <kaber@trash.net> wrote:
> This patch changes dev->qdisc_list to a double-linked list. This solves
> the performance problems when destroying qdiscs with large number of inner
> qdiscs.
I don't see how this bit is correct:
@@ -831,7 +832,7 @@
read_unlock(&dev_base_lock);
cb->args[0] = idx;
- cb->args[1] = q_idx;
+ cb->args[1] = q_idx - 1;
return skb->len;
}
The changes to the qdisc_list traversal loop above this hunk does not
change what the final q_idx value is going to be. The simplest
example is if the list is empty, for which q_idx will end up being
zero both before and after your changes.
Please enlighten me :)
next prev parent reply other threads:[~2004-08-04 16:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-03 15:24 [PATCH 2.6 3/5]: Use double-linked list for dev->qdisc_list Patrick McHardy
2004-08-03 15:35 ` Stephen Hemminger
2004-08-03 19:22 ` Patrick McHardy
2004-08-03 15:38 ` [PATCH 2.6] cache align qdisc data Stephen Hemminger
2004-08-03 19:17 ` Patrick McHardy
2004-08-03 20:31 ` Stephen Hemminger
2004-08-03 20:42 ` Patrick McHardy
2004-08-03 21:05 ` Stephen Hemminger
2004-08-04 16:51 ` David S. Miller
2004-08-04 16:43 ` David S. Miller [this message]
2004-08-04 19:55 ` [PATCH 2.6 3/5]: Use double-linked list for dev->qdisc_list Patrick McHardy
2004-08-04 20:43 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040804094308.606f79bd.davem@redhat.com \
--to=davem@redhat.com \
--cc=kaber@trash.net \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).