From: Roger Luethi <rl@hellgate.ch>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: netdev@oss.sgi.com, linux-kernel@vger.kernel.org
Subject: [2/3] via-rhine: de-isolate PHY
Date: Sun, 8 Aug 2004 16:02:59 +0200 [thread overview]
Message-ID: <20040808140259.GA8575@k3.hellgate.ch> (raw)
In-Reply-To: <20040808140216.GA8181@k3.hellgate.ch>
PHYs may come up isolated. Make sure we can send data to them. This code
section needs a clean-up, but I prefer to merge this fix in isolation.
Report and suggested fix by Tam, Ming Dat (Tommy).
Signed-off-by: Roger Luethi <rl@hellgate.ch>
--- linux-2.6.8-rc3-mm1/drivers/net/via-rhine.c.01 2004-08-08 12:36:03.440855262 +0200
+++ linux-2.6.8-rc3-mm1/drivers/net/via-rhine.c 2004-08-08 13:15:24.527527919 +0200
@@ -896,7 +896,10 @@ static int __devinit rhine_init_one(stru
pci_set_drvdata(pdev, dev);
{
+ u16 mii_cmd;
int mii_status = mdio_read(dev, phy_id, 1);
+ mii_cmd = mdio_read(dev, phy_id, MII_BMCR) & ~BMCR_ISOLATE;
+ mdio_write(dev, phy_id, MII_BMCR, mii_cmd);
if (mii_status != 0xffff && mii_status != 0x0000) {
rp->mii_if.advertising = mdio_read(dev, phy_id, 4);
printk(KERN_INFO "%s: MII PHY found at address "
next prev parent reply other threads:[~2004-08-08 14:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-08 14:02 [0/3] via-rhine: experimental patches Roger Luethi
2004-08-08 14:02 ` [1/3] via-rhine: suspend/resume support Roger Luethi
2004-08-08 14:02 ` Roger Luethi [this message]
2004-08-08 14:03 ` [3/3] via-rhine: small fixes Roger Luethi
2004-08-10 2:08 ` [0/3] via-rhine: experimental patches Lee Revell
2004-08-10 7:10 ` Roger Luethi
2004-08-10 7:16 ` Lee Revell
-- strict thread matches above, loose matches on Subject: below --
2004-08-08 19:53 [2/3] via-rhine: de-isolate PHY Manfred Spraul
2004-08-08 20:05 ` Roger Luethi
2004-08-08 21:04 ` Manfred Spraul
2004-08-08 21:54 ` Roger Luethi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040808140259.GA8575@k3.hellgate.ch \
--to=rl@hellgate.ch \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).