* [PATCH]: Disable local bh's when grabing qdisc_tree_lock in tc_dump_tfilter
@ 2004-08-08 14:53 Patrick McHardy
2004-08-10 0:05 ` David S. Miller
0 siblings, 1 reply; 2+ messages in thread
From: Patrick McHardy @ 2004-08-08 14:53 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev
[-- Attachment #1: Type: text/plain, Size: 59 bytes --]
I missed this one when fixing locking in __qdisc_destroy.
[-- Attachment #2: tc_dump_tfilter-bh.diff --]
[-- Type: text/x-patch, Size: 988 bytes --]
# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
# 2004/08/08 14:15:49+02:00 kaber@kaber.coreworks.de
# [PKT_SCHED]: Disable local bh's when grabing qdisc_tree_lock in tc_dump_tfilter
#
# Signed-off-by: Patrick McHardy <kaber@trash.net>
#
# net/sched/cls_api.c
# 2004/08/08 14:15:30+02:00 kaber@kaber.coreworks.de +2 -2
# [PKT_SCHED]: Disable local bh's when grabing qdisc_tree_lock in tc_dump_tfilter
#
diff -Nru a/net/sched/cls_api.c b/net/sched/cls_api.c
--- a/net/sched/cls_api.c 2004-08-08 14:17:46 +02:00
+++ b/net/sched/cls_api.c 2004-08-08 14:17:46 +02:00
@@ -387,7 +387,7 @@
if ((dev = dev_get_by_index(tcm->tcm_ifindex)) == NULL)
return skb->len;
- read_lock(&qdisc_tree_lock);
+ read_lock_bh(&qdisc_tree_lock);
if (!tcm->tcm_parent)
q = dev->qdisc_sleeping;
else
@@ -444,7 +444,7 @@
if (cl)
cops->put(q, cl);
out:
- read_unlock(&qdisc_tree_lock);
+ read_unlock_bh(&qdisc_tree_lock);
dev_put(dev);
return skb->len;
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH]: Disable local bh's when grabing qdisc_tree_lock in tc_dump_tfilter
2004-08-08 14:53 [PATCH]: Disable local bh's when grabing qdisc_tree_lock in tc_dump_tfilter Patrick McHardy
@ 2004-08-10 0:05 ` David S. Miller
0 siblings, 0 replies; 2+ messages in thread
From: David S. Miller @ 2004-08-10 0:05 UTC (permalink / raw)
To: Patrick McHardy; +Cc: netdev
On Sun, 08 Aug 2004 16:53:18 +0200
Patrick McHardy <kaber@trash.net> wrote:
> I missed this one when fixing locking in __qdisc_destroy.
Ok, applied. Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-08-10 0:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-08-08 14:53 [PATCH]: Disable local bh's when grabing qdisc_tree_lock in tc_dump_tfilter Patrick McHardy
2004-08-10 0:05 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).