From: Adrian Bunk <bunk@fs.tum.de>
To: acme@conectiva.com.br
Cc: linux-kernel@vger.kernel.org, davem@redhat.com, netdev@oss.sgi.com
Subject: [2.6 patch] atalk compile errors with SYSCTL=n
Date: Thu, 12 Aug 2004 00:47:47 +0200 [thread overview]
Message-ID: <20040811224747.GQ26174@fs.tum.de> (raw)
I'm getting the following compile error in 2.6.8-rc4-mm1 (but it
doesn't seem to be specific to -mm) with CONFIG_SYSCTL=n:
<-- snip -->
...
LD .tmp_vmlinux1
net/built-in.o(.init.text+0x74db): In function `atalk_init':
: undefined reference to `atalk_register_sysctl'
make: *** [.tmp_vmlinux1] Error 1
<-- snip -->
The following patch fixes this issue:
Signed-off-by: Adrian Bunk <bunk@fs.tum.de>
--- linux-2.6.8-rc4-mm1-full/net/appletalk/ddp.c.old 2004-08-12 00:44:33.000000000 +0200
+++ linux-2.6.8-rc4-mm1-full/net/appletalk/ddp.c 2004-08-12 00:45:08.000000000 +0200
@@ -68,8 +68,10 @@
struct atalk_addr *sa);
extern void aarp_proxy_remove(struct net_device *dev, struct atalk_addr *sa);
+#ifdef CONFIG_SYSCTL
extern void atalk_register_sysctl(void);
extern void atalk_unregister_sysctl(void);
+#endif
struct datalink_proto *ddp_dl, *aarp_dl;
static struct proto_ops atalk_dgram_ops;
@@ -1905,7 +1907,9 @@
register_netdevice_notifier(&ddp_notifier);
aarp_proto_init();
atalk_proc_init();
+#ifdef CONFIG_SYSCTL
atalk_register_sysctl();
+#endif
return 0;
}
module_init(atalk_init);
next reply other threads:[~2004-08-11 22:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-11 22:47 Adrian Bunk [this message]
2004-08-12 0:01 ` [2.6 patch] atalk compile errors with SYSCTL=n Stephen Hemminger
2004-08-12 8:47 ` Adrian Bunk
2004-08-18 21:47 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040811224747.GQ26174@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=acme@conectiva.com.br \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).