* [PATCH] missing statics in atm
@ 2004-08-14 14:33 Christoph Hellwig
2004-08-16 2:18 ` David S. Miller
0 siblings, 1 reply; 2+ messages in thread
From: Christoph Hellwig @ 2004-08-14 14:33 UTC (permalink / raw)
To: davem; +Cc: netdev
--- 1.35/net/atm/clip.c 2004-07-13 15:39:15 +02:00
+++ edited/net/atm/clip.c 2004-08-11 12:00:00 +02:00
@@ -47,8 +47,8 @@
#endif
-struct net_device *clip_devs = NULL;
-struct atm_vcc *atmarpd = NULL;
+static struct net_device *clip_devs;
+static struct atm_vcc *atmarpd;
static struct neigh_table clip_tbl;
static struct timer_list idle_timer;
static int start_timer = 1;
===== net/atm/ipcommon.h 1.1 vs edited =====
--- 1.1/net/atm/ipcommon.h 2002-02-05 18:40:00 +01:00
+++ edited/net/atm/ipcommon.h 2004-08-11 11:59:21 +02:00
@@ -12,9 +12,6 @@
#include <linux/netdevice.h>
#include <linux/atmdev.h>
-
-extern struct net_device *clip_devs;
-
/*
* Appends all skbs from "from" to "to". The operation is atomic with respect
* to all other skb operations on "from" or "to".
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] missing statics in atm
2004-08-14 14:33 [PATCH] missing statics in atm Christoph Hellwig
@ 2004-08-16 2:18 ` David S. Miller
0 siblings, 0 replies; 2+ messages in thread
From: David S. Miller @ 2004-08-16 2:18 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: netdev
On Sat, 14 Aug 2004 16:33:24 +0200
Christoph Hellwig <hch@lst.de> wrote:
> -struct net_device *clip_devs = NULL;
> -struct atm_vcc *atmarpd = NULL;
> +static struct net_device *clip_devs;
> +static struct atm_vcc *atmarpd;
...
> -
> -extern struct net_device *clip_devs;
> -
Works for me. Patch applied, thanks Christoph.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-08-16 2:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-08-14 14:33 [PATCH] missing statics in atm Christoph Hellwig
2004-08-16 2:18 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).