From: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
To: "YOSHIFUJI Hideaki / ?$B5HF#1QL@" <yoshfuji@linux-ipv6.org>
Cc: jmorris@redhat.com, davem@redhat.com, netdev@oss.sgi.com
Subject: Re: [PATCH] SLAB_PANIC cleanup
Date: Wed, 18 Aug 2004 01:24:05 -0300 [thread overview]
Message-ID: <20040818042404.GB1007@conectiva.com.br> (raw)
In-Reply-To: <20040817.155942.51047516.yoshfuji@linux-ipv6.org>
Em Tue, Aug 17, 2004 at 03:59:42PM +0900, YOSHIFUJI Hideaki / ?$B5HF#1QL@ escreveu:
> In article <Xine.LNX.4.44.0408170237020.7736-100000@dhcp83-76.boston.redhat.com> (at Tue, 17 Aug 2004 02:43:38 -0400 (EDT)), James Morris <jmorris@redhat.com> says:
>
> It generally seems okay. Just a few things for readability.
>
> > diff -urN -X dontdiff linux-2.6.8.1-mm1.o/net/core/neighbour.c linux-2.6.8.1-mm1.w/net/core/neighbour.c
> > --- linux-2.6.8.1-mm1.o/net/core/neighbour.c 2004-06-16 01:18:56.000000000 -0400
> > +++ linux-2.6.8.1-mm1.w/net/core/neighbour.c 2004-08-17 02:57:22.888296160 -0400
> > @@ -1165,12 +1165,9 @@
> > if (!tbl->kmem_cachep)
> > tbl->kmem_cachep = kmem_cache_create(tbl->id,
> > tbl->entry_size,
> > - 0, SLAB_HWCACHE_ALIGN,
> > + 0, SLAB_HWCACHE_ALIGN|
> > + SLAB_PANIC,
>
> I rather prefer
> tbl->entry_size, 0,
> SLAB_HWCACHE_ALIGN|SLAB_PANIC,
I rather prefer:
SLAB_HWCACHE_ALIGN | SLAB_PANIC,
Regards,
- Arnaldo
next prev parent reply other threads:[~2004-08-18 4:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-17 6:43 [PATCH] SLAB_PANIC cleanup James Morris
2004-08-17 6:59 ` YOSHIFUJI Hideaki / 吉藤英明
2004-08-18 4:24 ` Arnaldo Carvalho de Melo [this message]
2004-08-17 9:07 ` Christoph Hellwig
2004-08-17 13:38 ` James Morris
2004-08-17 14:07 ` Christoph Hellwig
2004-08-18 4:28 ` Arnaldo Carvalho de Melo
2004-08-18 21:56 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040818042404.GB1007@conectiva.com.br \
--to=acme@conectiva.com.br \
--cc=davem@redhat.com \
--cc=jmorris@redhat.com \
--cc=netdev@oss.sgi.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).