From: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
To: Christoph Hellwig <hch@infradead.org>
Cc: James Morris <jmorris@redhat.com>,
"David S. Miller" <davem@redhat.com>,
netdev@oss.sgi.com
Subject: Re: [PATCH] SLAB_PANIC cleanup
Date: Wed, 18 Aug 2004 01:28:00 -0300 [thread overview]
Message-ID: <20040818042800.GC1007@conectiva.com.br> (raw)
In-Reply-To: <20040817150739.A22153@infradead.org>
Em Tue, Aug 17, 2004 at 03:07:39PM +0100, Christoph Hellwig escreveu:
> On Tue, Aug 17, 2004 at 09:38:16AM -0400, James Morris wrote:
> > Yes, although I'm not clear on what should be done. Returning an error
> > via an initcall does not do anything, so if these were built statically,
> > then the kernel would go on running after they failed. This is a general
> > problem. e.g. IPv6, which is commonly built as a module, will panic if
> > kmem_cache_create() fails during module load in several places.
>
> The ipv6 behaviour is definnitly bad. OOM situations shouldn't panic
> the kernel.
>
> If something is can be built modular it surely isn't important enough to
> panic the kernel on bootup if it can't initialize - after all people can
> run a kernel without the module loaded just fine.
Agreed, not because it is "not important", but because panicing at module
load, even in very rare cases is unnacceptable IMHO.
- Arnaldo
next prev parent reply other threads:[~2004-08-18 4:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-17 6:43 [PATCH] SLAB_PANIC cleanup James Morris
2004-08-17 6:59 ` YOSHIFUJI Hideaki / 吉藤英明
2004-08-18 4:24 ` Arnaldo Carvalho de Melo
2004-08-17 9:07 ` Christoph Hellwig
2004-08-17 13:38 ` James Morris
2004-08-17 14:07 ` Christoph Hellwig
2004-08-18 4:28 ` Arnaldo Carvalho de Melo [this message]
2004-08-18 21:56 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040818042800.GC1007@conectiva.com.br \
--to=acme@conectiva.com.br \
--cc=davem@redhat.com \
--cc=hch@infradead.org \
--cc=jmorris@redhat.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).