From: Harald Welte <laforge@netfilter.org>
To: "David S. Miller" <davem@redhat.com>
Cc: yasuyuki.kozakai@toshiba.co.jp, kaber@trash.net,
kadlec@blackhole.kfki.hu, kisza@securityaudit.hu,
netfilter-devel@lists.netfilter.org, usagi-core@linux-ipv6.org,
netdev@oss.sgi.com
Subject: Re: Do you know about skb_header_pointer() ?
Date: Thu, 19 Aug 2004 19:00:40 +0200 [thread overview]
Message-ID: <20040819170040.GW3921@sunbeam.de.gnumonks.org> (raw)
In-Reply-To: <20040819071750.67f0e924.davem@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1237 bytes --]
On Thu, Aug 19, 2004 at 07:17:50AM -0700, David S. Miller wrote:
> On Thu, 19 Aug 2004 11:44:01 +0200
> Harald Welte <laforge@netfilter.org> wrote:
>
> > http://lists.netfilter.org/pipermail/netfilter-devel/2004-August/016277.html
>
> I totally disagree with this change.
Ok, that's fine with me. Let's stay with the skb_header_pointer(),
which by the way [as expected] is not visible on my profile runs.
Still, I am curious to know if anyone on one of the Cc'ed mailinglists
can imagine a case where parts of the header up and including the tcp
options could be non-linear.
And no, I do not want to know this in order to say that
skb_heder_pointer() is bad. I just want to know, because then we might
still need some magic for those cases in order to avoid a case where we
end up with per-rule copies or similar stuff again.
Thanks!
--
- Harald Welte <laforge@netfilter.org> http://www.netfilter.org/
============================================================================
"Fragmentation is like classful addressing -- an interesting early
architectural error that shows how much experimentation was going
on while IP was being designed." -- Paul Vixie
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2004-08-19 17:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200408190721.QAA02944@toshiba.co.jp>
2004-08-19 9:44 ` Do you know about skb_header_pointer() ? Harald Welte
2004-08-19 14:16 ` David S. Miller
2004-08-19 16:55 ` Harald Welte
2004-08-19 14:17 ` David S. Miller
2004-08-19 17:00 ` Harald Welte [this message]
2004-08-19 17:27 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040819170040.GW3921@sunbeam.de.gnumonks.org \
--to=laforge@netfilter.org \
--cc=davem@redhat.com \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=kisza@securityaudit.hu \
--cc=netdev@oss.sgi.com \
--cc=netfilter-devel@lists.netfilter.org \
--cc=usagi-core@linux-ipv6.org \
--cc=yasuyuki.kozakai@toshiba.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).