* Re: [Kernel-janitors] ip_gre.c: update last_rx after netif_rx [not found] <411E62D3.8070808@uranium235.org> @ 2004-08-21 8:36 ` maximilian attems 2004-08-23 20:36 ` max attems 0 siblings, 1 reply; 2+ messages in thread From: maximilian attems @ 2004-08-21 8:36 UTC (permalink / raw) To: Jay Bourque; +Cc: kernel-janitors, netdev On Sat, 14 Aug 2004, Jay Bourque wrote: > Fix to update last_rx after netif_rx > This is my first patch so I'd appreciate any feedback. > > -Jay > > --- linux-2.6.8.1/net/ipv4/ip_gre.c Sat Aug 14 05:55:48 2004 > +++ linux-2.6.8.1/net/ipv4/ip_gre.c.new Sat Aug 14 12:17:16 2004 > @@ -646,6 +646,7 @@ int ipgre_rcv(struct sk_buff *skb) > nf_reset(skb); > ipgre_ecn_decapsulate(iph, skb); > netif_rx(skb); > + tunnel->dev->last_rx = jiffies; > read_unlock(&ipgre_lock); > return(0); > } doesn't look complete, see patch below, but please read on: the kj todo has an entry about "update last_rx after netif_rx", i wonder what that timestamping is good for, and newer sources 2.4.27 and 2.6.8 show 2 occurences of last_rx. patches doing that are for young 2.4: http://seclists.org/linux-kernel/2001/Feb/4846.html i presume that this task is outdated, thanks for putting light on that. -- maks kernel janitor http://janitor.kernelnewbies.org/ ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Kernel-janitors] ip_gre.c: update last_rx after netif_rx 2004-08-21 8:36 ` [Kernel-janitors] ip_gre.c: update last_rx after netif_rx maximilian attems @ 2004-08-23 20:36 ` max attems 0 siblings, 0 replies; 2+ messages in thread From: max attems @ 2004-08-23 20:36 UTC (permalink / raw) To: Jay Bourque, kernel-janitors, netdev hello jay, On Sat, 21 Aug 2004, maximilian attems wrote: > On Sat, 14 Aug 2004, Jay Bourque wrote: > > > Fix to update last_rx after netif_rx > > This is my first patch so I'd appreciate any feedback. > > > > -Jay .. > i presume that this task is outdated, well nobody is really interested in aboves issue, thanks for bringing up that old dust, task removed from kernel janitor TODO. please choose another item of the kj TODO list? happy to read you soon. -- maks kernel janitor http://janitor.kernelnewbies.org/ ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-08-23 20:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <411E62D3.8070808@uranium235.org>
2004-08-21 8:36 ` [Kernel-janitors] ip_gre.c: update last_rx after netif_rx maximilian attems
2004-08-23 20:36 ` max attems
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).