netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: Thomas Graf <tgraf@suug.ch>
Cc: herbert@gondor.apana.org.au, kuznet@ms2.inr.ac.ru,
	hadi@cyberus.ca, netdev@oss.sgi.com
Subject: Re: [PATCH] allow setting mtu and txqlen via RTM_SETLINK and provide txqlen via RTM_GETLINK
Date: Tue, 24 Aug 2004 10:32:05 -0700	[thread overview]
Message-ID: <20040824103205.1ea9c999.davem@redhat.com> (raw)
In-Reply-To: <20040824120442.GA21296@postel.suug.ch>

On Tue, 24 Aug 2004 14:04:42 +0200
Thomas Graf <tgraf@suug.ch> wrote:

> * Herbert Xu <E1BzYMJ-000208-00@gondolin.me.apana.org.au> 2004-08-24 20:16
> > Please think about the meaning of the value.  Is anyone going to have a queue
> > bigger than 2^32?
> > 
> > And if the answer is yes, then please use u64.
> 
> Can you please explain the actual reason for using a fixed width
> type when all existing numeric attributes use arch depedent types?

Because otherwise things will break and explode for 32-bit
binaries running on 64-bit kernels, which is the situation
for the majority of userland on some platforms.

We have a compatability layer to translate 32-bit system
call structures to/from 64-bit data types.  But such
a scheme does not work for things like netlink sockets
where it is the data stream via read/write calls that
contains the structures.

Also, we eventually want to be able to transmit netlink
messages over real networks to remote clients.

Therefore, like any other real network protocol, we should
use fixed sized types in the data.

Stop bickering and use a u32, or I'll make that change for
you :-)

  reply	other threads:[~2004-08-24 17:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-23 20:51 [PATCH] allow setting mtu and txqlen via RTM_SETLINK and provide txqlen via RTM_GETLINK Thomas Graf
2004-08-24  2:26 ` Herbert Xu
2004-08-24  9:49   ` Thomas Graf
2004-08-24 10:16     ` Herbert Xu
2004-08-24 12:04       ` Thomas Graf
2004-08-24 17:32         ` David S. Miller [this message]
2004-08-24 18:15           ` Thomas Graf
2004-08-24 20:47           ` [RFC/PATCH] Convert architecture dependent rtnetlink attribute to fixed sized ones Thomas Graf
2004-08-24 22:44             ` David S. Miller
2004-08-24 16:25       ` [PATCH] allow setting mtu and txqlen via RTM_SETLINK and provide txqlen via RTM_GETLINK Thomas Graf
2004-08-24 17:32         ` David S. Miller
2004-08-24 18:08           ` Thomas Graf
2004-08-25  0:34             ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040824103205.1ea9c999.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=hadi@cyberus.ca \
    --cc=herbert@gondor.apana.org.au \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=netdev@oss.sgi.com \
    --cc=tgraf@suug.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).