From: "David S. Miller" <davem@redhat.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: jmorris@redhat.com, netdev@oss.sgi.com
Subject: Re: RFC: pskb_expand_head instead of skb_copy in skb_checksum_help
Date: Tue, 24 Aug 2004 17:17:09 -0700 [thread overview]
Message-ID: <20040824171709.57a613bd.davem@redhat.com> (raw)
In-Reply-To: <20040824110532.GA10241@gondor.apana.org.au>
On Tue, 24 Aug 2004 21:05:32 +1000
Herbert Xu <herbert@gondor.apana.org.au> wrote:
> Here is the patch that you wanted to shoot holes at :)
>
> The idea is simple. None of the callers of skb_checksum are passing it
> skb's which are shared. They may be cloned however. But the application
> checksum is always in the skb header so there is no need to linearise it.
>
> Supposing all these assumptions are correct, then we can avoid the overhead
> of skb_copy() and get away with pskb_expand_head().
I'm going to apply this.
If your assertion is wrong, then the skb_shared() BUG() will trigger
in pskb_expand_head() and we will know :-)
prev parent reply other threads:[~2004-08-25 0:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-24 11:05 RFC: pskb_expand_head instead of skb_copy in skb_checksum_help Herbert Xu
2004-08-24 18:55 ` David S. Miller
2004-08-24 20:53 ` James Morris
2004-08-25 0:17 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040824171709.57a613bd.davem@redhat.com \
--to=davem@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=jmorris@redhat.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).