From: "David S. Miller" <davem@redhat.com>
To: Thomas Graf <tgraf@suug.ch>
Cc: herbert@gondor.apana.org.au, kuznet@ms2.inr.ac.ru,
hadi@cyberus.ca, netdev@oss.sgi.com
Subject: Re: [PATCH] allow setting mtu and txqlen via RTM_SETLINK and provide txqlen via RTM_GETLINK
Date: Tue, 24 Aug 2004 17:34:37 -0700 [thread overview]
Message-ID: <20040824173437.453fd7b0.davem@redhat.com> (raw)
In-Reply-To: <20040824180825.GJ21296@postel.suug.ch>
On Tue, 24 Aug 2004 20:08:25 +0200
Thomas Graf <tgraf@suug.ch> wrote:
> --- 1.33/include/linux/rtnetlink.h Mon Apr 5 23:41:40 2004
> +++ 1.35/include/linux/rtnetlink.h Tue Aug 24 20:06:53 2004
> @@ -540,6 +540,8 @@
> IFLA_QDISC,
> IFLA_STATS,
> IFLA_COST,
> + IFLA_TXQLEN,
> + IFLA_MAP,
> #define IFLA_COST IFLA_COST
> IFLA_PRIORITY,
> #define IFLA_PRIORITY IFLA_PRIORITY
You cannot add new IFLA_* numbers to the middle of the
enumeration, that changes the subsequent existing
IFLA_* values which are hard-coded in userspace applications.
I've fixed this and applied your patch, thanks Thomas.
Could you please provide a 2.4.x version?
prev parent reply other threads:[~2004-08-25 0:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-23 20:51 [PATCH] allow setting mtu and txqlen via RTM_SETLINK and provide txqlen via RTM_GETLINK Thomas Graf
2004-08-24 2:26 ` Herbert Xu
2004-08-24 9:49 ` Thomas Graf
2004-08-24 10:16 ` Herbert Xu
2004-08-24 12:04 ` Thomas Graf
2004-08-24 17:32 ` David S. Miller
2004-08-24 18:15 ` Thomas Graf
2004-08-24 20:47 ` [RFC/PATCH] Convert architecture dependent rtnetlink attribute to fixed sized ones Thomas Graf
2004-08-24 22:44 ` David S. Miller
2004-08-24 16:25 ` [PATCH] allow setting mtu and txqlen via RTM_SETLINK and provide txqlen via RTM_GETLINK Thomas Graf
2004-08-24 17:32 ` David S. Miller
2004-08-24 18:08 ` Thomas Graf
2004-08-25 0:34 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040824173437.453fd7b0.davem@redhat.com \
--to=davem@redhat.com \
--cc=hadi@cyberus.ca \
--cc=herbert@gondor.apana.org.au \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@oss.sgi.com \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).