Fw: [Bugme-new] [Bug 3278] New: Missing include statements

Fw: [Bugme-new] [Bug 3278] New: Missing include statements

[Andrew Morton]

Begin forwarded message:

Date: Thu, 26 Aug 2004 05:55:52 -0700
From: bugme-daemon@osdl.org
To: bugme-new@lists.osdl.org
Subject: [Bugme-new] [Bug 3278] New: Missing include statements


http://bugme.osdl.org/show_bug.cgi?id=3278

           Summary: Missing include statements
    Kernel Version: 2.6.9-rc1
            Status: NEW
          Severity: normal
             Owner: laforge@gnumonks.org
         Submitter: brix@gimp.org


Distribution: Gentoo Linux

Hardware Environment: IBM ThinkPad X31

Software Environment:
Linux sponge 2.6.8.1 #7 Wed Aug 25 22:37:20 CEST 2004 i686 Intel(R) Pentium(R) M
processor 1300MHz GenuineIntel GNU/Linux

Gnu C                  3.3.3
Gnu make               3.80
binutils               2.14.90.0.8
util-linux             2.12
mount                  2.12
module-init-tools      3.0
e2fsprogs              1.35
pcmcia-cs              3.2.5
PPP                    2.4.1
nfs-utils              1.0.6
Linux C Library        2.3.3
Dynamic linker (ldd)   2.3.3
Procps                 3.1.15
Net-tools              1.60
Kbd                    1.12
Sh-utils               5.2.1
Modules Loaded         arc4 ieee80211_crypt_wep crc32 usbhid eth1394 ds ipw2100
firmware_class ieee80211 ieee80211_crypt ohci1394 ieee1394 yenta_socket
pcmcia_core snd_intel8x0m snd_intel8x0 snd_ac97_codec snd_mpu401_uart
snd_rawmidi snd_pcm_oss snd_pcm snd_page_alloc snd_timer snd_mixer_oss snd
soundcore ibm_acpi

Problem Description:

The following files, perhaps more, should #include <linux/netfilter_ipv4.h> or
symbols like NF_IP_PRE_ROUTING will be unknown.

  net/ipv4/netfilter/ip_conntrack_proto_tcp.c
  net/ipv4/netfilter/ip_conntrack_proto_udp.c
  net/ipv4/netfilter/ip_conntrack_proto_icmp.c


Steps to reproduce: Enable netfilter connection tracking and compile.

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

Re: Fw: [Bugme-new] [Bug 3278] New: Missing include statements

[David S. Miller]

This was fixed 2 days ago :-)

# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
#   2004/08/24 11:23:53-07:00 lkml@felipe-alfaro.com 
#   [NETFILTER]: Missing netfilter_ipv4.c include in conntrack proto code.
#   
#   Signed-off-by: Felipe Alfaro Solana <lkml@felipe-alfaro.com>
#   Signed-off-by: David S. Miller <davem@redhat.com>
# 
# net/ipv4/netfilter/ip_conntrack_proto_udp.c
#   2004/08/24 11:23:03-07:00 lkml@felipe-alfaro.com +1 -0
#   [NETFILTER]: Missing netfilter_ipv4.c include in conntrack proto code.
# 
# net/ipv4/netfilter/ip_conntrack_proto_tcp.c
#   2004/08/24 11:23:03-07:00 lkml@felipe-alfaro.com +1 -0
#   [NETFILTER]: Missing netfilter_ipv4.c include in conntrack proto code.
# 
# net/ipv4/netfilter/ip_conntrack_proto_icmp.c
#   2004/08/24 11:23:03-07:00 lkml@felipe-alfaro.com +1 -0
#   [NETFILTER]: Missing netfilter_ipv4.c include in conntrack proto code.
# 
diff -Nru a/net/ipv4/netfilter/ip_conntrack_proto_icmp.c b/net/ipv4/netfilter/ip_conntrack_proto_icmp.c
--- a/net/ipv4/netfilter/ip_conntrack_proto_icmp.c	2004-08-26 13:43:32 -07:00
+++ b/net/ipv4/netfilter/ip_conntrack_proto_icmp.c	2004-08-26 13:43:32 -07:00
@@ -15,6 +15,7 @@
 #include <net/ip.h>
 #include <net/checksum.h>
 #include <linux/netfilter.h>
+#include <linux/netfilter_ipv4.h>
 #include <linux/netfilter_ipv4/ip_conntrack.h>
 #include <linux/netfilter_ipv4/ip_conntrack_core.h>
 #include <linux/netfilter_ipv4/ip_conntrack_protocol.h>
diff -Nru a/net/ipv4/netfilter/ip_conntrack_proto_tcp.c b/net/ipv4/netfilter/ip_conntrack_proto_tcp.c
--- a/net/ipv4/netfilter/ip_conntrack_proto_tcp.c	2004-08-26 13:43:32 -07:00
+++ b/net/ipv4/netfilter/ip_conntrack_proto_tcp.c	2004-08-26 13:43:32 -07:00
@@ -33,6 +33,7 @@
 #include <net/tcp.h>
 
 #include <linux/netfilter.h>
+#include <linux/netfilter_ipv4.h>
 #include <linux/netfilter_ipv4/ip_conntrack.h>
 #include <linux/netfilter_ipv4/ip_conntrack_protocol.h>
 #include <linux/netfilter_ipv4/lockhelp.h>
diff -Nru a/net/ipv4/netfilter/ip_conntrack_proto_udp.c b/net/ipv4/netfilter/ip_conntrack_proto_udp.c
--- a/net/ipv4/netfilter/ip_conntrack_proto_udp.c	2004-08-26 13:43:32 -07:00
+++ b/net/ipv4/netfilter/ip_conntrack_proto_udp.c	2004-08-26 13:43:32 -07:00
@@ -14,6 +14,7 @@
 #include <linux/udp.h>
 #include <net/checksum.h>
 #include <linux/netfilter.h>
+#include <linux/netfilter_ipv4.h>
 #include <linux/netfilter_ipv4/ip_conntrack_protocol.h>
 
 unsigned long ip_ct_udp_timeout = 30*HZ;