From: "David S. Miller" <davem@redhat.com>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: hadi@znyx.com, netdev@oss.sgi.com
Subject: Re: [PATCH 2.6] netem update
Date: Fri, 27 Aug 2004 16:56:59 -0700 [thread overview]
Message-ID: <20040827165659.616ed762.davem@redhat.com> (raw)
In-Reply-To: <20040827121752.6b7fdf82@dell_ss3.pdx.osdl.net>
On Fri, 27 Aug 2004 12:17:52 -0700
Stephen Hemminger <shemminger@osdl.org> wrote:
> This is a third revision of the netem extensions which provides
> * packet duplication
> * correlated random number
> * loading distribution table
>
> The API is backwards compatible and now uses nested elements to allow
> for easier future changes.
Looks great, applied. A 2.4.x version is coming? :-)
Also, if someone is bored, can we get the pkt_sched.h
enumeration stuff cleaned up a bit? I mean, instead
of all of these error prone FOO_MAX tricks, just do
what we do for the netlink headers.
enum {
FOO_A,
FOO_B,
...
__FOO_MAX,
};
#define FOO_MAX (__FOO_MAX - 1)
This way to add new enumerations is just a one line
change and less error prone.
prev parent reply other threads:[~2004-08-27 23:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-27 19:17 [PATCH 2.6] netem update Stephen Hemminger
2004-08-27 23:56 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040827165659.616ed762.davem@redhat.com \
--to=davem@redhat.com \
--cc=hadi@znyx.com \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).